Skip to content

Latest commit

 

History

History
74 lines (46 loc) · 4.13 KB

CONTRIBUTING.md

File metadata and controls

74 lines (46 loc) · 4.13 KB

Contributing to Flatland Benchmarks

Contributions are welcome, and they are greatly appreciated! Every little bit helps, and credit will always be given.

Types of Contributions

Report Bugs

Report bugs using our issue tracker.

If you are reporting a bug, please make sure to fill out the appropriate issue template.

Fix Bugs

Look through the repository issue tracker for bugs. Anything tagged with "bug" and "help wanted" is open to whoever wants to implement it.

Implement Features

Look through the repository issue tracker for features. Anything tagged with "enhancement" and "help wanted" is open to whoever wants to implement it.

Write Documentation

Add markdown to the docs folder. See GitHub Markdown.

Submit Feedback

The best way to send feedback is to file an issue.

If you are proposing a feature:

  • Explain in detail how it would work.
  • Keep the scope as narrow as possible, to make it easier to implement.
  • Remember that this is a volunteer-driven project, and that contributions are welcome :)

Review Pull Requests

Feel free to comment on open prs. Please contact us if you want to become a core team member. Core team members are assigned as reviewers to all prs by default. The review of a core team member is required for prs from non-members of the core team.

Technical Guidelines

Clean Code

Please adhere to the general Clean Code principles. For instance, we write short and concise functions and use appropriate naming to ensure readability.

Pull Requests

  1. Open a pull request on GitHub targeting the main branch. Make sure to fill out the template.
  • Principle 1: A review from a core team member is automatically requested. At least one approval is required to merge for non-core team members.
  • Principle 2: Formulate your expectations on risk (e.g. low/mid/high) and feedback/discussion (e.g. high: new concept XYZ, minor: refactoring).
  1. Once successfully reviewed and status checks passed, squash-merge the PR. This collapses all the commits into one and merges it into the main branch. Please adjust the subject line and body of the commit to accurately reflect your changes and prefix the commit with one of the labels of Conventional Commit messages.

Details

We have GitHub ruleset in place for the main branch enforcing: