cmd/maddy: Remove debug directive hack for command line argument

Author: foxcpp

cmd/maddy/main.go

@@ -75,19 +75,6 @@ func main() {
 		os.Exit(1)
 	}
 
-	if log.DefaultLogger.Debug {
-		// Insert 'debug' directive so other config blocks will inherit it.
-		skipInsert := false
-		for _, node := range cfg {
-			if node.Name == "debug" {
-				skipInsert = true
-			}
-		}
-		if !skipInsert {
-			cfg = append(cfg, config.Node{Name: "debug"})
-		}
-	}
-
 	// Make sure all paths we are going to use are absolute
 	// before we change the working directory.
 	config.StateDirectory, err = filepath.Abs(config.StateDirectory)

maddy.go

@@ -37,7 +37,7 @@ func Start(cfg []config.Node) error {
 	globals.Bool("auth_perdomain", false, false, nil)
 	globals.StringList("auth_domains", false, false, nil, nil)
 	globals.Custom("log", false, false, defaultLogOutput, logOutput, &log.DefaultLogger.Out)
-	globals.Bool("debug", false, false, &log.DefaultLogger.Debug)
+	globals.Bool("debug", false, log.DefaultLogger.Debug, &log.DefaultLogger.Debug)
 	globals.AllowUnknown()
 	unmatched, err := globals.Process()
 	if err != nil {