From 4a5f379832d8c659ac6f4749e6df0400603a1315 Mon Sep 17 00:00:00 2001 From: John Weldon Date: Sat, 22 Feb 2025 13:47:14 -0700 Subject: [PATCH] framework/log: Fix Logger usages in tests --- internal/storage/blob/test_blob.go | 3 ++- internal/target/remote/dane_delivery_test.go | 3 ++- internal/target/remote/mxauth_test.go | 6 ++++-- 3 files changed, 8 insertions(+), 4 deletions(-) diff --git a/internal/storage/blob/test_blob.go b/internal/storage/blob/test_blob.go index 9672efea..8f3d0bcb 100644 --- a/internal/storage/blob/test_blob.go +++ b/internal/storage/blob/test_blob.go @@ -39,10 +39,11 @@ func TestStore(t *testing.T, newStore func() module.BlobStore, cleanStore func(m prng := rand.New(randSrc) store := newStore() + l := testutils.Logger(t, "imapsql") b, err := imapsql.New("sqlite3", ":memory:", imapsql2.ExtBlobStore{Base: store}, imapsql.Opts{ PRNG: prng, - Log: testutils.Logger(t, "imapsql"), + Log: &l, }, ) if err != nil { diff --git a/internal/target/remote/dane_delivery_test.go b/internal/target/remote/dane_delivery_test.go index 2b921c7d..377f7cfc 100644 --- a/internal/target/remote/dane_delivery_test.go +++ b/internal/target/remote/dane_delivery_test.go @@ -32,7 +32,8 @@ import ( ) func targetWithExtResolver(t *testing.T, zones map[string]mockdns.Zone) (*mockdns.Server, *Target) { - dnsSrv, err := mockdns.NewServerWithLogger(zones, testutils.Logger(t, "mockdns"), false) + l := testutils.Logger(t, "mockdns") + dnsSrv, err := mockdns.NewServerWithLogger(zones, &l, false) if err != nil { t.Fatal(err) } diff --git a/internal/target/remote/mxauth_test.go b/internal/target/remote/mxauth_test.go index e332bdb4..978567c5 100644 --- a/internal/target/remote/mxauth_test.go +++ b/internal/target/remote/mxauth_test.go @@ -303,7 +303,8 @@ func TestRemoteDelivery_AuthMX_DNSSEC(t *testing.T) { }, } - dnsSrv, err := mockdns.NewServerWithLogger(zones, testutils.Logger(t, "mockdns"), false) + l := testutils.Logger(t, "mockdns") + dnsSrv, err := mockdns.NewServerWithLogger(zones, &l, false) if err != nil { t.Fatal(err) } @@ -342,7 +343,8 @@ func TestRemoteDelivery_AuthMX_DNSSEC_Fail(t *testing.T) { }, } - dnsSrv, err := mockdns.NewServerWithLogger(zones, testutils.Logger(t, "mockdns"), false) + l := testutils.Logger(t, "mockdns") + dnsSrv, err := mockdns.NewServerWithLogger(zones, &l, false) if err != nil { t.Fatal(err) }