Skip to content

Commit 519dc6c

Browse files
authored
fix(build): Use Node 14 in "Size Check" job to fix CI runs on master (#5324)
Set "Size Limit" job node version to 14 to fix Ember build failing. Because of how the size-limit-action handles runs on master, it actually builds the SDKs again instead of using the build cache like in PR contexts. With this patch we fix the CI runs on our end to unblock releases and make CI pass on master again
1 parent 40d26be commit 519dc6c

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

.github/workflows/build.yml

+4-1
Original file line numberDiff line numberDiff line change
@@ -187,7 +187,10 @@ jobs:
187187
- name: Set up Node
188188
uses: actions/setup-node@v1
189189
with:
190-
node-version: ${{ env.DEFAULT_NODE_VERSION }}
190+
# The size limit action runs `yarn` and `yarn build` when this job is executed on
191+
# `master`. We can't change this without making changes to the action, so we'll
192+
# use Node 14 for now.
193+
node-version: '14'
191194
- name: Check dependency cache
192195
uses: actions/cache@v2
193196
with:

0 commit comments

Comments
 (0)