Skip to content

Commit 94a07bb

Browse files
authored
chore(remix): Update package to 7.x structure (#5266)
This is a follow-up to #5256 and #5264, which added a skeleton remix SDK to the repo. The template that was used to create the new package had parts of the 6.x package structure and configuration still in it. This fixes that by bringing everything up to date to match our other packages.
1 parent ef30920 commit 94a07bb

File tree

5 files changed

+15
-37
lines changed

5 files changed

+15
-37
lines changed

packages/remix/package.json

+6-8
Original file line numberDiff line numberDiff line change
@@ -21,12 +21,12 @@
2121
"@sentry/node": "7.1.1",
2222
"@sentry/react": "7.1.1",
2323
"@sentry/tracing": "7.1.1",
24+
"@sentry/types": "7.1.1",
2425
"@sentry/utils": "7.1.1",
2526
"@sentry/webpack-plugin": "1.18.9",
2627
"tslib": "^1.9.3"
2728
},
2829
"devDependencies": {
29-
"@sentry/types": "7.1.1",
3030
"@types/webpack": "^4.41.31",
3131
"@remix-run/node": "^1.4.3",
3232
"@remix-run/react": "^1.4.3"
@@ -43,27 +43,25 @@
4343
}
4444
},
4545
"scripts": {
46-
"build": "run-p build:rollup",
46+
"build": "run-p build:rollup build:types",
4747
"build:dev": "run-s build",
48-
"build:esm": "tsc -p tsconfig.esm.json",
4948
"build:rollup": "rollup -c rollup.npm.config.js",
5049
"build:types": "tsc -p tsconfig.types.json",
51-
"build:watch": "run-p build:esm:watch",
50+
"build:watch": "run-p build:rollup:watch build:types:watch",
5251
"build:dev:watch": "run-s build:watch",
53-
"build:esm:watch": "tsc -p tsconfig.esm.json --watch",
5452
"build:rollup:watch": "rollup -c rollup.npm.config.js --watch",
5553
"build:types:watch": "tsc -p tsconfig.types.json --watch",
5654
"build:npm": "ts-node ../../scripts/prepack.ts && npm pack ./build",
57-
"clean": "rimraf build coverage",
55+
"circularDepCheck": "madge --circular src/index.ts",
56+
"clean": "rimraf build coverage sentry-remix-*.tgz",
5857
"fix": "run-s fix:eslint fix:prettier",
5958
"fix:eslint": "eslint . --format stylish --fix",
6059
"fix:prettier": "prettier --write \"{src,test,scripts}/**/*.ts\"",
61-
"link:yarn": "yarn link",
6260
"lint": "run-s lint:prettier lint:eslint",
6361
"lint:eslint": "eslint . --cache --cache-location '../../eslintcache/' --format stylish",
6462
"lint:prettier": "prettier --check \"{src,test,scripts}/**/*.ts\"",
6563
"test": "run-s test:unit",
66-
"test:unit": "jest --passWithNoTests",
64+
"test:unit": "jest",
6765
"test:watch": "jest --watch"
6866
},
6967
"volta": {

packages/remix/src/flags.ts

-18
This file was deleted.

packages/remix/src/performance/client.tsx

+1-3
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,6 @@ import { Transaction, TransactionContext } from '@sentry/types';
22
import { getGlobalObject, logger } from '@sentry/utils';
33
import * as React from 'react';
44

5-
import { IS_DEBUG_BUILD } from '../flags';
6-
75
const DEFAULT_TAGS = {
86
'routing.instrumentation': 'remix-router',
97
} as const;
@@ -85,7 +83,7 @@ export function remixRouterInstrumentation(useEffect: UseEffect, useLocation: Us
8583
export function withSentryRouteTracing<P extends Record<string, unknown>, R extends React.FC<P>>(OrigApp: R): R {
8684
// Early return when any of the required functions is not available.
8785
if (!_useEffect || !_useLocation || !_useMatches || !_customStartTransaction) {
88-
IS_DEBUG_BUILD && logger.warn('Remix SDK was unable to wrap your root because of one or more missing parameters.');
86+
__DEBUG_BUILD__ && logger.warn('Remix SDK was unable to wrap your root because of one or more missing parameters.');
8987

9088
// @ts-ignore Setting more specific React Component typing for `R` generic above
9189
// will break advanced type inference done by react router params

packages/remix/test/tsconfig.json

+8
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
1+
// TODO Once https://github.com/microsoft/TypeScript/issues/33094 is done (if it ever is), this file can disappear, as
2+
// it's purely a placeholder to satisfy VSCode.
3+
4+
{
5+
"extends": "../tsconfig.test.json",
6+
7+
"include": ["./**/*"]
8+
}

packages/remix/tsconfig.esm.json

-8
This file was deleted.

0 commit comments

Comments
 (0)