-
Notifications
You must be signed in to change notification settings - Fork 922
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
imgproc should follow a <figure/> model to be more semantically correct #1005
Comments
That's a nice idea! Is it likely to break anything (I can't see anything obvious...)? |
@LisaFC does the imgproc shortcode need to have alt text added (or is there another way to add alt text that marries this shortcode with Hugo's approach)? Note: images either need For example, I could see:
And then in the improc code:
I can add this to my pull request if this shortcode does not work with Hugo's method of adding alt text to a page bundle image. |
FWIW I've done this in a markdown hook using a number of different methods I've found around to also make responsive images. See render-image.html in yusaopeny_docs The code used looks like |
Current output of
imgproc
from docsy-example site:To be more semantically aligned and to improve accessibility, I propose using
<figure>
and<figcaption>
for images included in this manner, which creates a programmatic association between the image and the additional text, providing more context for screen readers :The text was updated successfully, but these errors were encountered: