Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lunr search is broken in latest docsy release #1111

Closed
shanmydell opened this issue Jul 25, 2022 · 8 comments · Fixed by #1112
Closed

Lunr search is broken in latest docsy release #1111

shanmydell opened this issue Jul 25, 2022 · 8 comments · Fixed by #1112
Assignees
Labels
bug Something isn't working

Comments

@shanmydell
Copy link

https://github.com/dell/csm-docs

Please refer to the code above.

Locally also it is broken with GH pages also it is broken

Note: With 0.2.0 release only GH page is broken , as this is a major blocked , please look into this as soon as possible

@shanmydell
Copy link
Author

shanmydell commented Jul 25, 2022

@chalin @Marzal @arnaudlevy : Could you please look into this issue.

@coulof
Copy link

coulof commented Jul 25, 2022

When doing a search the JS console errors:

main.min.3bff53fa2e8d9a2c4d0b3eeea5987ff2f2cc9a0f4eccb730274827d5e7cd5538.js:1 Uncaught TypeError: Cannot read properties of undefined (reading '*')
    at o (main.min.3bff53fa2e8d9a2c4d0b3eeea5987ff2f2cc9a0f4eccb730274827d5e7cd5538.js:1:3755)
    at HTMLInputElement.<anonymous> (main.min.3bff53fa2e8d9a2c4d0b3eeea5987ff2f2cc9a0f4eccb730274827d5e7cd5538.js:1:1993)
    at HTMLInputElement.dispatch (jquery-3.6.0.min.js:2:43064)
    at v.handle (jquery-3.6.0.min.js:2:41048)

@chalin chalin added the bug Something isn't working label Jul 25, 2022
@chalin
Copy link
Collaborator

chalin commented Jul 25, 2022

I confirm that I'm seeing the same error. @shanmydell - thanks for the link to the website that you're seeing the problem with. I'll take a closer look shortly.

/cc @nate-double-u @thisisobate since we have a sit that is being switched over to Lunr

@Marzal
Copy link
Contributor

Marzal commented Jul 25, 2022

With Gitlab Pages and [email protected] I see no error using Lunr

https://gitlab.com/Marzal/mundolibre

@chalin
Copy link
Collaborator

chalin commented Jul 25, 2022

@chalin
Copy link
Collaborator

chalin commented Jul 25, 2022

Thanks for the feedback @Marzal. Hopefully the fix in #1112 will leave your site fully functional -- I think it will, but in case it affects the styling of the close-search-results button, please let me know.

@shanmydell
Copy link
Author

@chalin : thanks for the quick turnaround

@chalin
Copy link
Collaborator

chalin commented Jul 26, 2022

Post-merge comments are still welcome @geriom.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants