Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mermaid graphs not working with gitGraph type #1130

Closed
lschierer opened this issue Jul 27, 2022 · 3 comments · Fixed by #1138
Closed

mermaid graphs not working with gitGraph type #1130

lschierer opened this issue Jul 27, 2022 · 3 comments · Fixed by #1138

Comments

@lschierer
Copy link

The following document works as expected:

 +++
 title = "History"
 date = 2022-07-26T16:13:48-04:00
 +++
 
 ```mermaid
 graph TD
   commit1 --> commit2
   commit2 --> commit3
```
 
 [^modeline]: # vim: shiftwidth=2:tabstop=2:expandtab

this alternate document displays just the title and an otherwise blank page.

+++
title = "History"
date = 2022-07-26T16:13:48-04:00
+++

```mermaid
gitGraph 
  commit 
  commit
  commit
```

[^modeline]: # vim: shiftwidth=2:tabstop=2:expandtab

as best I can tell, this implementation of mermaid does not support the gitGraph graph type. If this is a true statement, consider that a feature request. If it is something I am doing wrong, please consider it a bug against the documentation (please give an example of how).

I am using docy by checking it out into my hugo themes directory as a sub repository. I am currently at commit 1d126ab.

Thanks!!

@LisaFC
Copy link
Collaborator

LisaFC commented Jul 28, 2022

@gwatts you did the Mermaid integration if I remember correctly, do you have time to take a look at this?

@gwatts
Copy link
Contributor

gwatts commented Jul 29, 2022

Opened PR #1138 to upgrade Mermaid to the latest version; seems to fix the issue based on some quick local tests

@LisaFC
Copy link
Collaborator

LisaFC commented Jul 29, 2022

Thanks Gareth!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants