Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tabpane: assume text=true when ... #1749

Open
Tracked by #1746
chalin opened this issue Nov 17, 2023 · 1 comment
Open
Tracked by #1746

Tabpane: assume text=true when ... #1749

chalin opened this issue Nov 17, 2023 · 1 comment
Labels
e0-minutes Effort < 60 min enhancement New feature or request p2-medium

Comments

@chalin
Copy link
Collaborator

chalin commented Nov 17, 2023

Originally posted by @titusfortner in #1745 (comment)

Is there a (easy) way to have text=true be implicit when using % delimiter to get markdown in a tab? Most of our implementation is moving to markdown-only since we're importing code automatically from github and want to be able to make translations for everything else.

I couldn't figure out how the markdown was being enforced just looking at the code, so it may be happening in a completely different part of the code and definitely not easy to do this, but just curious.

Yeah, we're also using text tabs exclusively over on the OTel website. I don't think that I'd want to test for % delimiters (and I'm not sure that we can), but I agree that we look for something to trigger the text=true default on.

Off the top of my head, I'd consider triggering on the absence of lang parameters. I'll add this to the target fixes for next quarter.

@titusfortner
Copy link

That would work. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e0-minutes Effort < 60 min enhancement New feature or request p2-medium
Projects
None yet
Development

No branches or pull requests

2 participants