Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do a full review of docs to uniformly apply previous partial fix of param docs #1829

Closed
chalin opened this issue Feb 3, 2024 · 0 comments · Fixed by #1828
Closed

Do a full review of docs to uniformly apply previous partial fix of param docs #1829

chalin opened this issue Feb 3, 2024 · 0 comments · Fixed by #1828
Assignees
Labels
user guide Improvements to user guide
Milestone

Comments

@chalin
Copy link
Collaborator

chalin commented Feb 3, 2024

Originally posted by @Marzal in #1771 (comment)

Additional note: I just realized that in the chapter documenting how to enable GCSE search engine, the line gcs_engine_id = "xxxx" should be within params as well. We should address this in a separate ticket/PR IMHO.

Maybe there should be a full review, because there are more references without the params indications :

Thanks for the suggestion. /cc @svrnm

@chalin chalin changed the title Do a full review of docs to uniformly apply #1771 Do a full review of docs to uniformly apply previous partial fix of param docs Feb 3, 2024
@chalin chalin added the user guide Improvements to user guide label Feb 3, 2024
@chalin chalin added this to the 24Q1 milestone Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
user guide Improvements to user guide
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants