Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(max-allowed-line-length): add config to set max-allowed-line-length in pattern ingester #14070

Merged
merged 5 commits into from
Sep 6, 2024

Conversation

svennergr
Copy link
Contributor

What this PR does / why we need it:

The pattern ingester ingores log lines with >3k characters by default. This PR moves that limit into a config option, with a default of 3000.

@svennergr svennergr requested a review from a team as a code owner September 6, 2024 14:43
@github-actions github-actions bot added the type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories label Sep 6, 2024
Copy link
Contributor

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@grafanabot
Copy link
Collaborator

This PR must be merged before a backport PR will be created.

1 similar comment
@grafanabot
Copy link
Collaborator

This PR must be merged before a backport PR will be created.

@trevorwhitney trevorwhitney merged commit 0780456 into main Sep 6, 2024
63 checks passed
@trevorwhitney trevorwhitney deleted the svennergr/line-length-config-option branch September 6, 2024 20:16
grafanabot pushed a commit that referenced this pull request Sep 6, 2024
…ngth` in pattern ingester (#14070)

Co-authored-by: Trevor Whitney <[email protected]>
(cherry picked from commit 0780456)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport k218 product-approved size/M type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants