Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(blooms): Do not restart builders when planner disconnects (backport k227) #14922

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

loki-gh-app[bot]
Copy link
Contributor

@loki-gh-app loki-gh-app bot commented Nov 14, 2024

Backport 7669385 from #14783


What this PR does / why we need it:

Before this PR, when the planner restarted, all builders errored and restarted as well. This happened becvause even though we had a backoff mechanism, it was not reset when we could connect at least once succesfully.

This PR fixes this so builders just retry connecting to the planner again. We handle the EOF error we get when the planner disconnects to reset the backoff and start again.

Here's an example:

While the planner is down, there are no restarts
image

But we do print errors
image

We did this test using this backoff config:

bloom_build+: {
  builder+: {
    backoff_config+: {
      min_period: '1s',
      max_period: '1m',
    },
  },
},

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@loki-gh-app loki-gh-app bot added the backport label Nov 14, 2024
@loki-gh-app loki-gh-app bot requested a review from a team as a code owner November 14, 2024 15:58
@loki-gh-app loki-gh-app bot added size/M type/bug Somehing is not working as expected labels Nov 14, 2024
@loki-gh-app loki-gh-app bot requested a review from salvacorts November 14, 2024 15:58
@salvacorts salvacorts merged commit 213e8ee into k227 Nov 14, 2024
65 checks passed
@salvacorts salvacorts deleted the backport-14783-to-k227 branch November 14, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport size/M type/bug Somehing is not working as expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant