Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Shut down delete client on local rule-evaluator #15345

Merged

Conversation

salvacorts
Copy link
Contributor

@salvacorts salvacorts commented Dec 10, 2024

What this PR does / why we need it:

When the ruler evaluates rules locally (default), the deletes client is never stopped, hence preventing the workload from stopping gracefully.

I used this reproducer to test this out. When stopping the backend container:

  • Before the fix, the container never stopped within the grace period (5m).
  • With this PR changes, it finished seconds after requesting the container shutdown.

Which issue(s) this PR fixes:
Fixes #9523 (people shared Loki 3.x fixed it but I think the problem fixed in this PR falls within the issue description).

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@salvacorts salvacorts changed the title fix: Shut down delete client on local rule-evaluator shutdown fix: Shut down delete client on local rule-evaluator Dec 10, 2024
@salvacorts salvacorts marked this pull request as ready for review December 10, 2024 14:18
@salvacorts salvacorts requested a review from a team as a code owner December 10, 2024 14:18
@salvacorts salvacorts merged commit 42469cc into main Dec 11, 2024
60 checks passed
@salvacorts salvacorts deleted the salvacorts/fix-local-rule-eval-delete-client-termination branch December 11, 2024 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Loki Backend hangs indefinitely during shutdown
2 participants