Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in updateSlidesVisibility() causes wrong display in overview mode #3754

Open
steffen-mueller opened this issue Feb 24, 2025 · 0 comments

Comments

@steffen-mueller
Copy link

steffen-mueller commented Feb 24, 2025

I've stumbled across the following bug in updateSlidesVisibility() and digged into it.

Reproduction

Create a presentation with 2 slide columns:

  • One column with 15 slides (definitely more than the hardcoded viewDistance of 10 for the overview mode)
  • One column with just one slide

Run through the presentation slide by slide. When arriving at the last slide, switch on the overview.

Instead of seeing the 15 slides in the first column, you'll only see a sad placeholder for the whole column. Moving the cursor with the arrow keys fixes the problem again.

Cause

The updateSlidesVisibility() function uses the getPreviousVerticalIndex() value as the starting point for each of the columns. As we've left the first column at say index 14, the system calculates a view distance > 10 for the first slides in the column, hiding them. The lower slides are visible but because our overflow is focussed on vertical index 0 for our first slide in column 2, we cannot see them.

Potential solution

In overflow mode, updateSlidesVisibility() should consider each column from the index of the currently selected slide (so because we had the first slide in column 2 selected, index 0) and not the previous vertical index.

Would be cool if this would be fixed soon. It's a confusing moment to have an empty overview ;) Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant