Skip to content

Commit af9609d

Browse files
authored
fix: page index evaluator min/max args inverted (apache#648)
* fix: page index evaluator min/max args inverted * style: fix clippy lint in test
1 parent a6a3fd7 commit af9609d

File tree

3 files changed

+221
-27
lines changed

3 files changed

+221
-27
lines changed

crates/iceberg/src/expr/visitors/page_index_evaluator.rs

+8-8
Original file line numberDiff line numberDiff line change
@@ -246,10 +246,10 @@ impl<'a> PageIndexEvaluator<'a> {
246246
.zip(row_counts.iter())
247247
.map(|(item, &row_count)| {
248248
predicate(
249-
item.max.map(|val| {
249+
item.min.map(|val| {
250250
Datum::new(field_type.clone(), PrimitiveLiteral::Boolean(val))
251251
}),
252-
item.min.map(|val| {
252+
item.max.map(|val| {
253253
Datum::new(field_type.clone(), PrimitiveLiteral::Boolean(val))
254254
}),
255255
PageNullCount::from_row_and_null_counts(row_count, item.null_count),
@@ -262,10 +262,10 @@ impl<'a> PageIndexEvaluator<'a> {
262262
.zip(row_counts.iter())
263263
.map(|(item, &row_count)| {
264264
predicate(
265-
item.max
266-
.map(|val| Datum::new(field_type.clone(), PrimitiveLiteral::Int(val))),
267265
item.min
268266
.map(|val| Datum::new(field_type.clone(), PrimitiveLiteral::Int(val))),
267+
item.max
268+
.map(|val| Datum::new(field_type.clone(), PrimitiveLiteral::Int(val))),
269269
PageNullCount::from_row_and_null_counts(row_count, item.null_count),
270270
)
271271
})
@@ -276,10 +276,10 @@ impl<'a> PageIndexEvaluator<'a> {
276276
.zip(row_counts.iter())
277277
.map(|(item, &row_count)| {
278278
predicate(
279-
item.max
280-
.map(|val| Datum::new(field_type.clone(), PrimitiveLiteral::Long(val))),
281279
item.min
282280
.map(|val| Datum::new(field_type.clone(), PrimitiveLiteral::Long(val))),
281+
item.max
282+
.map(|val| Datum::new(field_type.clone(), PrimitiveLiteral::Long(val))),
283283
PageNullCount::from_row_and_null_counts(row_count, item.null_count),
284284
)
285285
})
@@ -312,13 +312,13 @@ impl<'a> PageIndexEvaluator<'a> {
312312
.zip(row_counts.iter())
313313
.map(|(item, &row_count)| {
314314
predicate(
315-
item.max.map(|val| {
315+
item.min.map(|val| {
316316
Datum::new(
317317
field_type.clone(),
318318
PrimitiveLiteral::Double(OrderedFloat::from(val)),
319319
)
320320
}),
321-
item.min.map(|val| {
321+
item.max.map(|val| {
322322
Datum::new(
323323
field_type.clone(),
324324
PrimitiveLiteral::Double(OrderedFloat::from(val)),

0 commit comments

Comments
 (0)