Skip to content

Commit 3d542c9

Browse files
author
Pierre-Etienne Bougue
committed
Remove sed for ssh replacement
Now that a cleaner solution is available
1 parent b8f5649 commit 3d542c9

File tree

2 files changed

+10
-3
lines changed

2 files changed

+10
-3
lines changed

.github/workflows/workflow.yml

+9-2
Original file line numberDiff line numberDiff line change
@@ -23,10 +23,18 @@ jobs:
2323
runs-on: ubuntu-latest
2424
steps:
2525
- uses: actions/checkout@v3
26+
- name: Generate github private access token
27+
id: ci-core-app-token
28+
uses: getsentry/[email protected]
29+
with:
30+
app_id: ${{ secrets.CI_CORE_APP_ID }}
31+
private_key: ${{ secrets.CI_CORE_APP_PEM }}
32+
- name: Config Github global url for ssh cases (add access token)
33+
run: |
34+
git config --global url."https://x-access-token:${{ steps.ci-core-app-token.outputs.token }}@github.com/hove-io/".insteadOf "[email protected]:hove-io/"
2635
- name: checkout submodules
2736
shell: bash
2837
run: |
29-
sed -i 's,git\@github.com:\([^/]*\)/\(.*\).git,https://github.com/\1/\2,' .gitmodules
3038
git submodule update --init --recursive
3139
- name: check submodules
3240
run: ./source/scripts/check_submodules.sh
@@ -135,7 +143,6 @@ jobs:
135143
pip install -r requirements_pre-commit.txt --upgrade
136144
- name: get submodule
137145
run: |
138-
sed -i 's,git\@github.com:\([^/]*\)/\(.*\).git,https://github.com/\1/\2,' .gitmodules
139146
git submodule update --init --recursive
140147
- name: Build Protobuf
141148
run: bash source/scripts/build_protobuf.sh

.gitmodules

+1-1
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
url = [email protected]:hove-io/SimpleAmqpClient.git
1010
[submodule "source/third_party/librabbitmq-c"]
1111
path = source/third_party/librabbitmq-c
12-
url = git@github.com:alanxz/rabbitmq-c.git
12+
url = https://github.com/alanxz/rabbitmq-c
1313
[submodule "source/chaos-proto"]
1414
path = source/chaos-proto
1515
url = [email protected]:hove-io/chaos-proto.git

0 commit comments

Comments
 (0)