Skip to content

Commit 7644d5c

Browse files
committed
Update pricing + tests + pre-commit
1 parent 086b8b5 commit 7644d5c

File tree

3 files changed

+21
-27
lines changed

3 files changed

+21
-27
lines changed

source/jormungandr/jormungandr/parking_space_availability/car/forseti.py

+6-4
Original file line numberDiff line numberDiff line change
@@ -81,8 +81,10 @@ def process_data(self, data, poi):
8181
if distance < self.distance:
8282
return ParkingPlaces(
8383
availability=parking.get('availability'),
84-
currency=parking.get('currency'),
85-
amount=parking.get('amount'),
86-
start_time=parking.get('startTime'),
87-
end_time=parking.get('endTime'),
84+
price=ParkingPlaces.Price(
85+
currency=parking.get('currency'),
86+
amount=parking.get('amount'),
87+
start_time=parking.get('startTime'),
88+
end_time=parking.get('endTime'),
89+
),
8890
)

source/jormungandr/jormungandr/parking_space_availability/car/parking_places.py

+1-11
Original file line numberDiff line numberDiff line change
@@ -61,10 +61,6 @@ def __init__(
6161
occupied_electric_vehicle=None,
6262
state=None,
6363
availability=None,
64-
currency=None,
65-
start_time=None,
66-
end_time=None,
67-
amount=None,
6864
price=None,
6965
):
7066
if available is not None:
@@ -90,13 +86,7 @@ def __init__(
9086
if availability is not None:
9187
self.availability = availability
9288
if price is not None:
93-
self.price = (
94-
price
95-
if price
96-
else ParkingPlaces.Price(
97-
currency=currency, amount=amount, start_time=start_time, end_time=end_time
98-
)
99-
)
89+
self.price = price
10090
if not total_places and any(n is not None for n in [available, occupied, available_PRM, occupied_PRM]):
10191
self.total_places = (available or 0) + (occupied or 0) + (available_PRM or 0) + (occupied_PRM or 0)
10292

source/jormungandr/jormungandr/parking_space_availability/car/tests/forseti_test.py

+14-12
Original file line numberDiff line numberDiff line change
@@ -59,26 +59,28 @@ def parking_space_availability_forseti_get_informations_test():
5959
"name": "786 Parking",
6060
"coord": {"lat": 42.368227, "lon": -83.0779357},
6161
"availability": True,
62-
"price": {
63-
"currency": "USD",
64-
"startTime": "2019-04-01T00:00:00Z",
65-
"endTime": "2019-04-01T23:59:59Z",
66-
"amount": 6000,
67-
},
62+
"currency": "USD",
63+
"amount": 6000,
64+
"startTime": "2019-04-01T00:00:00Z",
65+
"endTime": "2019-04-01T23:59:59Z",
6866
},
6967
],
7068
"pagination": {"start_page": 0, "items_on_page": 25, "items_per_page": 25, "total_result": 1},
7169
}
7270

7371
parking_places = ParkingPlaces(
7472
availability=True,
75-
currency='USD',
76-
start_time='2019-04-01T00:00:00Z',
77-
end_time='2019-04-01T23:59:59Z',
78-
amount=6000,
73+
price=ParkingPlaces.Price(
74+
currency='USD',
75+
amount=6000,
76+
start_time='2019-04-01T00:00:00Z',
77+
end_time='2019-04-01T23:59:59Z',
78+
),
7979
)
8080
provider = ForsetiProvider('http://forseti')
8181
provider._call_webservice = MagicMock(return_value=webservice_response)
8282
parking = provider.get_informations(poi)
83-
assert parking == parking_places
84-
print(parking)
83+
assert parking.price.currency == parking_places.price.currency
84+
assert parking.price.amount == parking_places.price.amount
85+
assert parking.price.start_time == parking_places.price.start_time
86+
assert parking.price.end_time == parking_places.price.end_time

0 commit comments

Comments
 (0)