Skip to content

Commit 2eaed2b

Browse files
committed
fix(prefer-strict-equal): provide suggestion instead of autofix
1 parent 782d8fa commit 2eaed2b

File tree

2 files changed

+26
-9
lines changed

2 files changed

+26
-9
lines changed

src/rules/__tests__/prefer-strict-equal.test.ts

+13-2
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,19 @@ ruleTester.run('prefer-strict-equal', rule, {
1212
invalid: [
1313
{
1414
code: 'expect(something).toEqual(somethingElse);',
15-
errors: [{ messageId: 'useToStrictEqual', column: 19, line: 1 }],
16-
output: 'expect(something).toStrictEqual(somethingElse);',
15+
errors: [
16+
{
17+
messageId: 'useToStrictEqual',
18+
column: 19,
19+
line: 1,
20+
suggestions: [
21+
{
22+
messageId: 'suggestReplaceWithStrictEqual',
23+
output: 'expect(something).toStrictEqual(somethingElse);',
24+
},
25+
],
26+
},
27+
],
1728
},
1829
],
1930
});

src/rules/prefer-strict-equal.ts

+13-7
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,8 @@ export default createRule({
1515
recommended: false,
1616
},
1717
messages: {
18-
useToStrictEqual: 'Use toStrictEqual() instead',
18+
useToStrictEqual: 'Use `toStrictEqual()` instead',
19+
suggestReplaceWithStrictEqual: 'Replace with `toStrictEqual()`',
1920
},
2021
fixable: 'code',
2122
type: 'suggestion',
@@ -36,14 +37,19 @@ export default createRule({
3637
isParsedEqualityMatcherCall(matcher, EqualityMatcher.toEqual)
3738
) {
3839
context.report({
39-
fix: fixer => [
40-
fixer.replaceText(
41-
matcher.node.property,
42-
EqualityMatcher.toStrictEqual,
43-
),
44-
],
4540
messageId: 'useToStrictEqual',
4641
node: matcher.node.property,
42+
suggest: [
43+
{
44+
messageId: 'suggestReplaceWithStrictEqual',
45+
fix: fixer => [
46+
fixer.replaceText(
47+
matcher.node.property,
48+
EqualityMatcher.toStrictEqual,
49+
),
50+
],
51+
},
52+
],
4753
});
4854
}
4955
},

0 commit comments

Comments
 (0)