Skip to content

Commit 4cfcf08

Browse files
committed
fix(no-if): report conditionals in call expressions
fixes #557
1 parent 8670c39 commit 4cfcf08

File tree

2 files changed

+15
-1
lines changed

2 files changed

+15
-1
lines changed

src/rules/__tests__/no-if.test.ts

+12
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,18 @@ ruleTester.run('conditional expressions', rule, {
2323
},
2424
],
2525
invalid: [
26+
{
27+
code: `it('foo', () => {
28+
expect(bar ? foo : baz).toBe(boo);
29+
})
30+
`,
31+
errors: [
32+
{
33+
data: { condition: 'conditional' },
34+
messageId: 'conditionalInTest',
35+
},
36+
],
37+
},
2638
{
2739
code: `it('foo', () => {
2840
const foo = bar ? foo : baz;

src/rules/no-if.ts

+3-1
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,9 @@ export default createRule({
7373

7474
return {
7575
CallExpression(node) {
76-
stack.push(isTestCase(node));
76+
if (isTestCase(node)) {
77+
stack.push(true);
78+
}
7779
},
7880
FunctionExpression() {
7981
stack.push(false);

0 commit comments

Comments
 (0)