Skip to content

Commit 7080952

Browse files
G-RathSimenB
authored andcommitted
feat: set no-jasmine-globals to error in recommended ruleset
BREAKING CHANGE: recommend erroring for `no-jasmine-globals` rule
1 parent 22113db commit 7080952

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

src/__tests__/__snapshots__/rules.test.ts.snap

+1-1
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ Object {
7070
"jest/no-export": "error",
7171
"jest/no-focused-tests": "error",
7272
"jest/no-identical-title": "error",
73-
"jest/no-jasmine-globals": "warn",
73+
"jest/no-jasmine-globals": "error",
7474
"jest/no-jest-import": "error",
7575
"jest/no-mocks-import": "error",
7676
"jest/no-standalone-expect": "error",

src/rules/no-jasmine-globals.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ export default createRule({
1212
docs: {
1313
category: 'Best Practices',
1414
description: 'Disallow Jasmine globals',
15-
recommended: 'warn',
15+
recommended: 'error',
1616
},
1717
messages: {
1818
illegalGlobal:

0 commit comments

Comments
 (0)