Skip to content

Commit 7730f75

Browse files
authored
fix(valid-title): ensure argument node is defined before accessing props (#538)
1 parent 5d8be9d commit 7730f75

File tree

2 files changed

+6
-1
lines changed

2 files changed

+6
-1
lines changed

src/rules/__tests__/valid-title.test.ts

+1
Original file line numberDiff line numberDiff line change
@@ -271,6 +271,7 @@ ruleTester.run('no-empty-title', rule, {
271271
'test(`${foo}`, function () {})',
272272
'test.concurrent(`${foo}`, function () {})',
273273
"it('foo', function () {})",
274+
'it.each([])()',
274275
"it.concurrent('foo', function () {})",
275276
"xdescribe('foo', function () {})",
276277
"xit('foo', function () {})",

src/rules/valid-title.ts

+5-1
Original file line numberDiff line numberDiff line change
@@ -81,12 +81,16 @@ export default createRule({
8181

8282
return {
8383
CallExpression(node: TSESTree.CallExpression) {
84-
if (!(isDescribe(node) || isTestCase(node)) || !node.arguments.length) {
84+
if (!isDescribe(node) && !isTestCase(node)) {
8585
return;
8686
}
8787

8888
const [argument] = getJestFunctionArguments(node);
8989

90+
if (!argument) {
91+
return;
92+
}
93+
9094
if (!isStringNode(argument)) {
9195
if (
9296
argument.type === AST_NODE_TYPES.BinaryExpression &&

0 commit comments

Comments
 (0)