Skip to content

Commit 78ccbef

Browse files
authored
fix(prefer-mock-promise-shorthand): ignore mockImplementation functions that have parameters (#1199)
1 parent 24e85c8 commit 78ccbef

File tree

2 files changed

+2
-1
lines changed

2 files changed

+2
-1
lines changed

src/rules/__tests__/prefer-mock-promise-shorthand.test.ts

+1
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,7 @@ ruleTester.run('prefer-mock-shorthand', rule, {
3939
'aVariable.mockReturnValue(Promise.reject().then(() => 1))',
4040
'aVariable.mockReturnValue(new Promise(resolve => resolve(1)))',
4141
'aVariable.mockReturnValue(new Promise((_, reject) => reject(1)))',
42+
"jest.spyOn(Thingy, 'method').mockImplementation(param => Promise.resolve(param));",
4243
dedent`
4344
aVariable.mockImplementation(() => {
4445
const value = new Date();

src/rules/prefer-mock-promise-shorthand.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -112,7 +112,7 @@ export default createRule({
112112
} else if (mockFnName === withOnce('mockImplementation', isOnce)) {
113113
const [arg] = node.arguments;
114114

115-
if (!isFunction(arg)) {
115+
if (!isFunction(arg) || arg.params.length !== 0) {
116116
return;
117117
}
118118

0 commit comments

Comments
 (0)