Skip to content

Commit a41a40e

Browse files
authored
fix(no-identical-title): always consider .each titles unique (#910)
1 parent bcc8176 commit a41a40e

File tree

2 files changed

+14
-4
lines changed

2 files changed

+14
-4
lines changed

src/rules/__tests__/no-identical-title.test.ts

+12-2
Original file line numberDiff line numberDiff line change
@@ -124,12 +124,12 @@ ruleTester.run('no-identical-title', rule, {
124124
dedent`
125125
describe.each\`
126126
description
127-
${'b'}
127+
$\{'b'}
128128
\`('$description', () => {});
129129
130130
describe.each\`
131131
description
132-
${'a'}
132+
$\{'a'}
133133
\`('$description', () => {});
134134
`,
135135
dedent`
@@ -141,6 +141,16 @@ ruleTester.run('no-identical-title', rule, {
141141
describe('nested', () => {});
142142
});
143143
`,
144+
dedent`
145+
describe.each\`\`('my title', value => {});
146+
describe.each\`\`('my title', value => {});
147+
describe.each([])('my title', value => {});
148+
describe.each([])('my title', value => {});
149+
`,
150+
dedent`
151+
describe.each([])('when the value is %s', value => {});
152+
describe.each([])('when the value is %s', value => {});
153+
`,
144154
],
145155
invalid: [
146156
{

src/rules/no-identical-title.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
1-
import { AST_NODE_TYPES } from '@typescript-eslint/experimental-utils';
21
import {
32
createRule,
3+
getNodeName,
44
getStringValue,
55
isDescribeCall,
66
isStringNode,
@@ -46,7 +46,7 @@ export default createRule({
4646
contexts.push(newDescribeContext());
4747
}
4848

49-
if (node.callee.type === AST_NODE_TYPES.TaggedTemplateExpression) {
49+
if (getNodeName(node.callee)?.endsWith('.each')) {
5050
return;
5151
}
5252

0 commit comments

Comments
 (0)