Skip to content

Commit a871775

Browse files
G-RathG-Rath
authored
fix(no-focused-tests): make reporting location consistent (#1443)
* test(no-focused-tests): add start and end ranges * fix(no-focused-tests): make reporting location consistent
1 parent 1ee0087 commit a871775

File tree

2 files changed

+105
-53
lines changed

2 files changed

+105
-53
lines changed

‎src/rules/__tests__/no-focused-tests.test.ts

+104-52
Original file line numberDiff line numberDiff line change
@@ -32,9 +32,11 @@ ruleTester.run('no-focused-tests', rule, {
3232
code: 'describe.only()',
3333
errors: [
3434
{
35-
messageId: 'focusedTest',
36-
column: 10,
3735
line: 1,
36+
column: 10,
37+
endLine: 1,
38+
endColumn: 14,
39+
messageId: 'focusedTest',
3840
suggestions: [
3941
{
4042
messageId: 'suggestRemoveFocus',
@@ -48,9 +50,11 @@ ruleTester.run('no-focused-tests', rule, {
4850
code: 'context.only()',
4951
errors: [
5052
{
51-
messageId: 'focusedTest',
52-
column: 9,
5353
line: 1,
54+
column: 9,
55+
endLine: 1,
56+
endColumn: 13,
57+
messageId: 'focusedTest',
5458
suggestions: [
5559
{
5660
messageId: 'suggestRemoveFocus',
@@ -65,9 +69,11 @@ ruleTester.run('no-focused-tests', rule, {
6569
code: 'describe.only.each()()',
6670
errors: [
6771
{
68-
messageId: 'focusedTest',
69-
column: 10,
7072
line: 1,
73+
column: 10,
74+
endLine: 1,
75+
endColumn: 14,
76+
messageId: 'focusedTest',
7177
suggestions: [
7278
{
7379
messageId: 'suggestRemoveFocus',
@@ -81,9 +87,11 @@ ruleTester.run('no-focused-tests', rule, {
8187
code: 'describe.only.each`table`()',
8288
errors: [
8389
{
84-
messageId: 'focusedTest',
85-
column: 10,
8690
line: 1,
91+
column: 10,
92+
endLine: 1,
93+
endColumn: 14,
94+
messageId: 'focusedTest',
8795
suggestions: [
8896
{
8997
messageId: 'suggestRemoveFocus',
@@ -97,9 +105,11 @@ ruleTester.run('no-focused-tests', rule, {
97105
code: 'describe["only"]()',
98106
errors: [
99107
{
100-
messageId: 'focusedTest',
101-
column: 10,
102108
line: 1,
109+
column: 10,
110+
endLine: 1,
111+
endColumn: 16,
112+
messageId: 'focusedTest',
103113
suggestions: [
104114
{
105115
messageId: 'suggestRemoveFocus',
@@ -113,9 +123,11 @@ ruleTester.run('no-focused-tests', rule, {
113123
code: 'it.only()',
114124
errors: [
115125
{
116-
messageId: 'focusedTest',
117-
column: 4,
118126
line: 1,
127+
column: 4,
128+
endLine: 1,
129+
endColumn: 8,
130+
messageId: 'focusedTest',
119131
suggestions: [
120132
{
121133
messageId: 'suggestRemoveFocus',
@@ -129,9 +141,11 @@ ruleTester.run('no-focused-tests', rule, {
129141
code: 'it.concurrent.only.each``()',
130142
errors: [
131143
{
132-
messageId: 'focusedTest',
133-
column: 15,
134144
line: 1,
145+
column: 15,
146+
endLine: 1,
147+
endColumn: 19,
148+
messageId: 'focusedTest',
135149
suggestions: [
136150
{
137151
messageId: 'suggestRemoveFocus',
@@ -145,9 +159,11 @@ ruleTester.run('no-focused-tests', rule, {
145159
code: 'it.only.each()()',
146160
errors: [
147161
{
148-
messageId: 'focusedTest',
149-
column: 4,
150162
line: 1,
163+
column: 4,
164+
endLine: 1,
165+
endColumn: 8,
166+
messageId: 'focusedTest',
151167
suggestions: [
152168
{
153169
messageId: 'suggestRemoveFocus',
@@ -161,9 +177,11 @@ ruleTester.run('no-focused-tests', rule, {
161177
code: 'it.only.each`table`()',
162178
errors: [
163179
{
164-
messageId: 'focusedTest',
165-
column: 4,
166180
line: 1,
181+
column: 4,
182+
endLine: 1,
183+
endColumn: 8,
184+
messageId: 'focusedTest',
167185
suggestions: [
168186
{
169187
messageId: 'suggestRemoveFocus',
@@ -177,9 +195,11 @@ ruleTester.run('no-focused-tests', rule, {
177195
code: 'it["only"]()',
178196
errors: [
179197
{
180-
messageId: 'focusedTest',
181-
column: 4,
182198
line: 1,
199+
column: 4,
200+
endLine: 1,
201+
endColumn: 10,
202+
messageId: 'focusedTest',
183203
suggestions: [
184204
{
185205
messageId: 'suggestRemoveFocus',
@@ -193,9 +213,11 @@ ruleTester.run('no-focused-tests', rule, {
193213
code: 'test.only()',
194214
errors: [
195215
{
196-
messageId: 'focusedTest',
197-
column: 6,
198216
line: 1,
217+
column: 6,
218+
endLine: 1,
219+
endColumn: 10,
220+
messageId: 'focusedTest',
199221
suggestions: [
200222
{
201223
messageId: 'suggestRemoveFocus',
@@ -209,9 +231,11 @@ ruleTester.run('no-focused-tests', rule, {
209231
code: 'test.concurrent.only.each()()',
210232
errors: [
211233
{
212-
messageId: 'focusedTest',
213-
column: 17,
214234
line: 1,
235+
column: 17,
236+
endLine: 1,
237+
endColumn: 21,
238+
messageId: 'focusedTest',
215239
suggestions: [
216240
{
217241
messageId: 'suggestRemoveFocus',
@@ -225,9 +249,11 @@ ruleTester.run('no-focused-tests', rule, {
225249
code: 'test.only.each()()',
226250
errors: [
227251
{
228-
messageId: 'focusedTest',
229-
column: 6,
230252
line: 1,
253+
column: 6,
254+
endLine: 1,
255+
endColumn: 10,
256+
messageId: 'focusedTest',
231257
suggestions: [
232258
{
233259
messageId: 'suggestRemoveFocus',
@@ -241,9 +267,11 @@ ruleTester.run('no-focused-tests', rule, {
241267
code: 'test.only.each`table`()',
242268
errors: [
243269
{
244-
messageId: 'focusedTest',
245-
column: 6,
246270
line: 1,
271+
column: 6,
272+
endLine: 1,
273+
endColumn: 10,
274+
messageId: 'focusedTest',
247275
suggestions: [
248276
{
249277
messageId: 'suggestRemoveFocus',
@@ -257,9 +285,11 @@ ruleTester.run('no-focused-tests', rule, {
257285
code: 'test["only"]()',
258286
errors: [
259287
{
260-
messageId: 'focusedTest',
261-
column: 6,
262288
line: 1,
289+
column: 6,
290+
endLine: 1,
291+
endColumn: 12,
292+
messageId: 'focusedTest',
263293
suggestions: [
264294
{
265295
messageId: 'suggestRemoveFocus',
@@ -273,9 +303,11 @@ ruleTester.run('no-focused-tests', rule, {
273303
code: 'fdescribe()',
274304
errors: [
275305
{
276-
messageId: 'focusedTest',
277-
column: 1,
278306
line: 1,
307+
column: 1,
308+
endLine: 1,
309+
endColumn: 10,
310+
messageId: 'focusedTest',
279311
suggestions: [
280312
{
281313
messageId: 'suggestRemoveFocus',
@@ -289,9 +321,11 @@ ruleTester.run('no-focused-tests', rule, {
289321
code: 'fit()',
290322
errors: [
291323
{
292-
messageId: 'focusedTest',
293-
column: 1,
294324
line: 1,
325+
column: 1,
326+
endLine: 1,
327+
endColumn: 4,
328+
messageId: 'focusedTest',
295329
suggestions: [
296330
{
297331
messageId: 'suggestRemoveFocus',
@@ -305,9 +339,11 @@ ruleTester.run('no-focused-tests', rule, {
305339
code: 'fit.each()()',
306340
errors: [
307341
{
308-
messageId: 'focusedTest',
309-
column: 1,
310342
line: 1,
343+
column: 1,
344+
endLine: 1,
345+
endColumn: 4,
346+
messageId: 'focusedTest',
311347
suggestions: [
312348
{
313349
messageId: 'suggestRemoveFocus',
@@ -321,9 +357,11 @@ ruleTester.run('no-focused-tests', rule, {
321357
code: 'fit.each`table`()',
322358
errors: [
323359
{
324-
messageId: 'focusedTest',
325-
column: 1,
326360
line: 1,
361+
column: 1,
362+
endLine: 1,
363+
endColumn: 4,
364+
messageId: 'focusedTest',
327365
suggestions: [
328366
{
329367
messageId: 'suggestRemoveFocus',
@@ -357,9 +395,11 @@ ruleTester.run('no-focused-tests (with imports)', rule, {
357395
`,
358396
errors: [
359397
{
360-
messageId: 'focusedTest',
361-
column: 10,
362398
line: 3,
399+
column: 10,
400+
endLine: 3,
401+
endColumn: 14,
402+
messageId: 'focusedTest',
363403
suggestions: [
364404
{
365405
messageId: 'suggestRemoveFocus',
@@ -382,9 +422,11 @@ ruleTester.run('no-focused-tests (with imports)', rule, {
382422
parserOptions: { sourceType: 'module' },
383423
errors: [
384424
{
385-
messageId: 'focusedTest',
386-
column: 14,
387425
line: 3,
426+
column: 14,
427+
endLine: 3,
428+
endColumn: 18,
429+
messageId: 'focusedTest',
388430
suggestions: [
389431
{
390432
messageId: 'suggestRemoveFocus',
@@ -406,9 +448,11 @@ ruleTester.run('no-focused-tests (with imports)', rule, {
406448
`,
407449
errors: [
408450
{
409-
messageId: 'focusedTest',
410-
column: 1,
411451
line: 3,
452+
column: 1,
453+
endLine: 3,
454+
endColumn: 10,
455+
messageId: 'focusedTest',
412456
suggestions: [
413457
{
414458
messageId: 'suggestRemoveFocus',
@@ -438,9 +482,11 @@ ruleTester.run('no-focused-tests (aliases)', rule, {
438482
parserOptions: { sourceType: 'module' },
439483
errors: [
440484
{
441-
messageId: 'focusedTest',
442-
column: 14,
443485
line: 3,
486+
column: 14,
487+
endLine: 3,
488+
endColumn: 18,
489+
messageId: 'focusedTest',
444490
suggestions: [
445491
{
446492
messageId: 'suggestRemoveFocus',
@@ -464,14 +510,18 @@ ruleTester.run('no-focused-tests (aliases)', rule, {
464510
parserOptions: { sourceType: 'module' },
465511
errors: [
466512
{
467-
messageId: 'focusedTest',
468-
column: 1,
469513
line: 3,
514+
column: 1,
515+
endLine: 3,
516+
endColumn: 17,
517+
messageId: 'focusedTest',
470518
},
471519
{
472-
messageId: 'focusedTest',
473-
column: 1,
474520
line: 4,
521+
column: 1,
522+
endLine: 4,
523+
endColumn: 17,
524+
messageId: 'focusedTest',
475525
},
476526
],
477527
},
@@ -484,9 +534,11 @@ ruleTester.run('no-focused-tests (aliases)', rule, {
484534
parserOptions: { sourceType: 'module' },
485535
errors: [
486536
{
487-
messageId: 'focusedTest',
488-
column: 9,
489537
line: 3,
538+
column: 9,
539+
endLine: 3,
540+
endColumn: 13,
541+
messageId: 'focusedTest',
490542
suggestions: [
491543
{
492544
messageId: 'suggestRemoveFocus',

‎src/rules/no-focused-tests.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ export default createRule({
3030
if (jestFnCall.name.startsWith('f')) {
3131
context.report({
3232
messageId: 'focusedTest',
33-
node,
33+
node: jestFnCall.head.node,
3434
suggest: [
3535
{
3636
messageId: 'suggestRemoveFocus',

0 commit comments

Comments
 (0)