Skip to content

Commit aa946a6

Browse files
authored
fix(valid-describe): false positive with template describe.each (#785)
1 parent 104e771 commit aa946a6

File tree

2 files changed

+11
-1
lines changed

2 files changed

+11
-1
lines changed

src/rules/__tests__/valid-describe.test.ts

+7
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,13 @@ ruleTester.run('valid-describe', rule, {
5050
if (hasOwnProperty(obj, key)) {
5151
}
5252
`,
53+
dedent`
54+
describe.each\`
55+
something | other
56+
${1} | ${2} |
57+
\`
58+
("$something", ({ something, other }) => { });
59+
`,
5360
],
5461
invalid: [
5562
{

src/rules/valid-describe.ts

+4-1
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,10 @@ export default createRule({
4545
create(context) {
4646
return {
4747
CallExpression(node) {
48-
if (!isDescribe(node)) {
48+
if (
49+
!isDescribe(node) ||
50+
node.callee.type === AST_NODE_TYPES.TaggedTemplateExpression
51+
) {
4952
return;
5053
}
5154

0 commit comments

Comments
 (0)