Skip to content

Commit b651443

Browse files
authored
fix(no-disabled-tests): don't report on it.todo & test.todo (#1137)
1 parent 5162b0f commit b651443

File tree

2 files changed

+5
-1
lines changed

2 files changed

+5
-1
lines changed

src/rules/__tests__/no-disabled-tests.test.ts

+1
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@ ruleTester.run('no-disabled-tests', rule, {
2323
'test.only("foo", function () {})',
2424
'test.concurrent("foo", function () {})',
2525
'describe[`${"skip"}`]("foo", function () {})',
26+
'it.todo("fill this later")',
2627
'var appliedSkip = describe.skip; appliedSkip.apply(describe)',
2728
'var calledSkip = it.skip; calledSkip.call(it)',
2829
'({ f: function () {} }).f()',

src/rules/no-disabled-tests.ts

+4-1
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,10 @@ export default createRule({
4444
if (jestFnCall.type === 'test') {
4545
testDepth++;
4646

47-
if (node.arguments.length < 2) {
47+
if (
48+
node.arguments.length < 2 &&
49+
jestFnCall.members.every(s => getAccessorValue(s) !== 'todo')
50+
) {
4851
context.report({ messageId: 'missingFunction', node });
4952
}
5053
}

0 commit comments

Comments
 (0)