Skip to content

Commit dfd2368

Browse files
authored
fix: use correct property hasSuggestions rather than hasSuggestion (#899)
1 parent 46ac6fc commit dfd2368

6 files changed

+7
-11
lines changed

src/index.ts

+2-6
Original file line numberDiff line numberDiff line change
@@ -8,15 +8,11 @@ type RuleModule = TSESLint.RuleModule<string, unknown[]> & {
88
meta: Required<Pick<TSESLint.RuleMetaData<string>, 'docs'>>;
99
};
1010

11-
// can be removed once we've on v3: https://github.com/typescript-eslint/typescript-eslint/issues/2060
11+
// can be removed once we've on v5 of `@typescript-eslint/experimental-utils`
1212
declare module '@typescript-eslint/experimental-utils/dist/ts-eslint/Rule' {
13-
export interface RuleMetaDataDocs {
14-
suggestion?: boolean;
15-
}
16-
1713
// eslint-disable-next-line @typescript-eslint/no-unused-vars
1814
export interface RuleMetaData<TMessageIds extends string> {
19-
hasSuggestion?: boolean;
15+
hasSuggestions?: boolean;
2016
}
2117
}
2218

src/rules/no-done-callback.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ export default createRule({
4747
},
4848
schema: [],
4949
type: 'suggestion',
50-
hasSuggestion: true,
50+
hasSuggestions: true,
5151
},
5252
defaultOptions: [],
5353
create(context) {

src/rules/no-focused-tests.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ export default createRule({
4949
},
5050
schema: [],
5151
type: 'suggestion',
52-
hasSuggestion: true,
52+
hasSuggestions: true,
5353
},
5454
defaultOptions: [],
5555
create: context => ({

src/rules/prefer-expect-assertions.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,7 @@ export default createRule<[RuleOptions], MessageIds>({
8484
suggestRemovingExtraArguments: 'Remove extra arguments',
8585
},
8686
type: 'suggestion',
87-
hasSuggestion: true,
87+
hasSuggestions: true,
8888
schema: [
8989
{
9090
type: 'object',

src/rules/prefer-strict-equal.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ export default createRule({
2121
},
2222
type: 'suggestion',
2323
schema: [],
24-
hasSuggestion: true,
24+
hasSuggestions: true,
2525
},
2626
defaultOptions: [],
2727
create(context) {

tools/regenerate-docs.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -114,7 +114,7 @@ const details: RuleDetails[] = Object.keys(config.configs.all.rules)
114114
description: rule.meta.docs.description,
115115
fixable: rule.meta.fixable
116116
? 'fixable'
117-
: rule.meta.hasSuggestion
117+
: rule.meta.hasSuggestions
118118
? 'suggest'
119119
: false,
120120
requiresTypeChecking: rule.meta.docs.requiresTypeChecking ?? false,

0 commit comments

Comments
 (0)