Skip to content

Commit f3e9e9a

Browse files
G-RathSimenB
authored andcommitted
feat(valid-describe): rename to valid-describe-callback
BREAKING CHANGE: renamed `valid-describe` to `valid-describe-callback`
1 parent b860084 commit f3e9e9a

File tree

5 files changed

+6
-6
lines changed

5 files changed

+6
-6
lines changed

README.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -190,7 +190,7 @@ installations requiring long-term consistency.
190190
| [require-hook](docs/rules/require-hook.md) | Require setup and teardown code to be within a hook | | |
191191
| [require-to-throw-message](docs/rules/require-to-throw-message.md) | Require a message for `toThrow()` | | |
192192
| [require-top-level-describe](docs/rules/require-top-level-describe.md) | Require test cases and hooks to be inside a `describe` block | | |
193-
| [valid-describe](docs/rules/valid-describe.md) | Enforce valid `describe()` callback | ![recommended][] | |
193+
| [valid-describe-callback](docs/rules/valid-describe-callback.md) | Enforce valid `describe()` callback | ![recommended][] | |
194194
| [valid-expect](docs/rules/valid-expect.md) | Enforce valid `expect()` usage | ![recommended][] | |
195195
| [valid-expect-in-promise](docs/rules/valid-expect-in-promise.md) | Ensure promises that have expectations in their chain are valid | ![recommended][] | |
196196
| [valid-title](docs/rules/valid-title.md) | Enforce valid titles | ![recommended][] | ![fixable][] |

docs/rules/valid-describe.md docs/rules/valid-describe-callback.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
# Enforce valid `describe()` callback (`valid-describe`)
1+
# Enforce valid `describe()` callback (`valid-describe-callback`)
22

33
Using an improper `describe()` callback function can lead to unexpected test
44
errors.

src/__tests__/__snapshots__/rules.test.ts.snap

+2-2
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ Object {
4949
"jest/require-to-throw-message": "error",
5050
"jest/require-top-level-describe": "error",
5151
"jest/unbound-method": "error",
52-
"jest/valid-describe": "error",
52+
"jest/valid-describe-callback": "error",
5353
"jest/valid-expect": "error",
5454
"jest/valid-expect-in-promise": "error",
5555
"jest/valid-title": "error",
@@ -78,7 +78,7 @@ Object {
7878
"jest/no-mocks-import": "error",
7979
"jest/no-standalone-expect": "error",
8080
"jest/no-test-prefixes": "error",
81-
"jest/valid-describe": "error",
81+
"jest/valid-describe-callback": "error",
8282
"jest/valid-expect": "error",
8383
"jest/valid-expect-in-promise": "error",
8484
"jest/valid-title": "error",

src/rules/__tests__/valid-describe.test.ts src/rules/__tests__/valid-describe-callback.test.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import { TSESLint } from '@typescript-eslint/experimental-utils';
22
import dedent from 'dedent';
33
import resolveFrom from 'resolve-from';
4-
import rule from '../valid-describe';
4+
import rule from '../valid-describe-callback';
55

66
const ruleTester = new TSESLint.RuleTester({
77
parser: resolveFrom(require.resolve('eslint'), 'espree'),
@@ -10,7 +10,7 @@ const ruleTester = new TSESLint.RuleTester({
1010
},
1111
});
1212

13-
ruleTester.run('valid-describe', rule, {
13+
ruleTester.run('valid-describe-callback', rule, {
1414
valid: [
1515
'describe.each([1, 2, 3])("%s", (a, b) => {});',
1616
'describe("foo", function() {})',
File renamed without changes.

0 commit comments

Comments
 (0)