Skip to content

Commit f636021

Browse files
authored
fix: don't include deprecated rules in all config (#664)
Resolves #663
1 parent d16b84c commit f636021

File tree

3 files changed

+14
-9
lines changed

3 files changed

+14
-9
lines changed

src/__tests__/__snapshots__/rules.test.ts.snap

-4
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@ Object {
2020
"jest/no-disabled-tests": "error",
2121
"jest/no-done-callback": "error",
2222
"jest/no-duplicate-hooks": "error",
23-
"jest/no-expect-resolves": "error",
2423
"jest/no-export": "error",
2524
"jest/no-focused-tests": "error",
2625
"jest/no-hooks": "error",
@@ -35,12 +34,9 @@ Object {
3534
"jest/no-standalone-expect": "error",
3635
"jest/no-test-prefixes": "error",
3736
"jest/no-test-return-statement": "error",
38-
"jest/no-truthy-falsy": "error",
39-
"jest/no-try-expect": "error",
4037
"jest/prefer-called-with": "error",
4138
"jest/prefer-expect-assertions": "error",
4239
"jest/prefer-hooks-on-top": "error",
43-
"jest/prefer-inline-snapshots": "error",
4440
"jest/prefer-spy-on": "error",
4541
"jest/prefer-strict-equal": "error",
4642
"jest/prefer-to-be-null": "error",

src/__tests__/rules.test.ts

+5-2
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,11 @@ import { existsSync } from 'fs';
22
import { resolve } from 'path';
33
import plugin from '../';
44

5-
const ruleNames = Object.keys(plugin.rules);
65
const numberOfRules = 44;
6+
const ruleNames = Object.keys(plugin.rules);
7+
const deprecatedRules = Object.entries(plugin.rules)
8+
.filter(([, rule]) => rule.meta.deprecated)
9+
.map(([name]) => name);
710

811
describe('rules', () => {
912
it('should have a corresponding doc for each rule', () => {
@@ -54,7 +57,7 @@ describe('rules', () => {
5457
'style',
5558
]);
5659
expect(Object.keys(recommendedConfigs.all.rules)).toHaveLength(
57-
ruleNames.length,
60+
ruleNames.length - deprecatedRules.length,
5861
);
5962
const allConfigRules = Object.values(recommendedConfigs)
6063
.map(config => Object.keys(config.rules))

src/index.ts

+9-3
Original file line numberDiff line numberDiff line change
@@ -48,9 +48,15 @@ const recommendedRules = Object.entries(rules)
4848
{},
4949
);
5050

51-
const allRules = Object.keys(rules).reduce<
52-
Record<string, TSESLint.Linter.RuleLevel>
53-
>((rules, key) => ({ ...rules, [`jest/${key}`]: 'error' }), {});
51+
const allRules = Object.entries(rules)
52+
.filter(([, rule]) => !rule.meta.deprecated)
53+
.reduce(
54+
(acc, [name]) => ({
55+
...acc,
56+
[`jest/${name}`]: 'error',
57+
}),
58+
{},
59+
);
5460

5561
const createConfig = (rules: Record<string, TSESLint.Linter.RuleLevel>) => ({
5662
plugins: ['jest'],

0 commit comments

Comments
 (0)