Skip to content

Commit fa08f09

Browse files
G-RathSimenB
authored andcommitted
feat: deprecate prefer-to-be-undefined rule
1 parent 4db9161 commit fa08f09

File tree

4 files changed

+6
-2
lines changed

4 files changed

+6
-2
lines changed

README.md

-1
Original file line numberDiff line numberDiff line change
@@ -184,7 +184,6 @@ installations requiring long-term consistency.
184184
| [prefer-spy-on](docs/rules/prefer-spy-on.md) | Suggest using `jest.spyOn()` | | ![fixable][] |
185185
| [prefer-strict-equal](docs/rules/prefer-strict-equal.md) | Suggest using `toStrictEqual()` | | ![suggest][] |
186186
| [prefer-to-be](docs/rules/prefer-to-be.md) | Suggest using `toBe()` for primitive literals | | ![fixable][] |
187-
| [prefer-to-be-undefined](docs/rules/prefer-to-be-undefined.md) | Suggest using `toBeUndefined()` | ![style][] | ![fixable][] |
188187
| [prefer-to-contain](docs/rules/prefer-to-contain.md) | Suggest using `toContain()` | ![style][] | ![fixable][] |
189188
| [prefer-to-have-length](docs/rules/prefer-to-have-length.md) | Suggest using `toHaveLength()` | ![style][] | ![fixable][] |
190189
| [prefer-todo](docs/rules/prefer-todo.md) | Suggest using `test.todo` | | ![fixable][] |

docs/rules/prefer-to-be-undefined.md

+4
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,9 @@
11
# Suggest using `toBeUndefined()` (`prefer-to-be-undefined`)
22

3+
## Deprecated
4+
5+
This rule has been deprecated in favor of [`prefer-to-be`](prefer-to-be.md).
6+
37
In order to have a better failure message, `toBeUndefined()` should be used upon
48
asserting expectations on undefined value.
59

src/__tests__/__snapshots__/rules.test.ts.snap

-1
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,6 @@ Object {
4242
"jest/prefer-spy-on": "error",
4343
"jest/prefer-strict-equal": "error",
4444
"jest/prefer-to-be": "error",
45-
"jest/prefer-to-be-undefined": "error",
4645
"jest/prefer-to-contain": "error",
4746
"jest/prefer-to-have-length": "error",
4847
"jest/prefer-todo": "error",

src/rules/prefer-to-be-undefined.ts

+2
Original file line numberDiff line numberDiff line change
@@ -46,6 +46,8 @@ export default createRule({
4646
messages: {
4747
useToBeUndefined: 'Use toBeUndefined() instead',
4848
},
49+
deprecated: true,
50+
replacedBy: ['prefer-to-be'],
4951
fixable: 'code',
5052
type: 'suggestion',
5153
schema: [],

0 commit comments

Comments
 (0)