Skip to content

Commit ff0349e

Browse files
sonnypSimenB
andauthored
feat(valid-expect): allow calling expect with no arguments (#1688)
This is particularly useful for jest-extended - https://jest-extended.jestcommunity.dev/docs/matchers/pass - https://jest-extended.jestcommunity.dev/docs/matchers/fail Co-authored-by: Simen Bekkhus <[email protected]>
1 parent deb6609 commit ff0349e

File tree

3 files changed

+6
-2
lines changed

3 files changed

+6
-2
lines changed

docs/rules/valid-expect.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ This rule is enabled by default.
5656
},
5757
minArgs: {
5858
type: 'number',
59-
minimum: 1,
59+
minimum: 0,
6060
},
6161
maxArgs: {
6262
type: 'number',

src/rules/__tests__/valid-expect.test.ts

+4
Original file line numberDiff line numberDiff line change
@@ -129,6 +129,10 @@ ruleTester.run('valid-expect', rule, {
129129
code: 'test("valid-expect", async () => { expect(Promise.resolve(2)).toResolve(); });',
130130
options: [{ asyncMatchers: ['toResolveWith'] }],
131131
},
132+
{
133+
code: 'expect().pass();',
134+
options: [{ minArgs: 0 }],
135+
},
132136
],
133137
invalid: [
134138
{

src/rules/valid-expect.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -176,7 +176,7 @@ export default createRule<[Options], MessageIds>({
176176
},
177177
minArgs: {
178178
type: 'number',
179-
minimum: 1,
179+
minimum: 0,
180180
},
181181
maxArgs: {
182182
type: 'number',

0 commit comments

Comments
 (0)