Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Rule named-snapshot #103

Closed
dmiller9911 opened this issue Apr 3, 2018 · 4 comments · Fixed by #1012
Closed

New Rule named-snapshot #103

dmiller9911 opened this issue Apr 3, 2018 · 4 comments · Fixed by #1012

Comments

@dmiller9911
Copy link

I was wondering if this repo would be open to a rule to enforce naming of snapshots. Options would be always | mutli | never

  • always - Enforce naming of snapshots even if there is only a singular snapshot.
  • multi - Enforce naming only if there are multiple snapshots in a test. naming from curly rule
  • never - Disallow naming of snapshots

I would be more than happy to contribute this rule. I plan to write it for one of my projects, and I wanted to check to make sure that this repo would be open to adding it before I open a PR.

@macklinu
Copy link
Collaborator

macklinu commented Apr 3, 2018

I personally like this idea. Wonder if the core contributors give it a thumbs up? Also wondering if the default option here should be never. 🤔

@SimenB
Copy link
Member

SimenB commented Apr 3, 2018

Yeah, I don't mind a rule for this.

Keep jestjs/jest#5847 in mind when implementing

@G-Rath
Copy link
Collaborator

G-Rath commented Dec 30, 2021

I've created a PR for this which supports always and multi, with multi being the default.

@github-actions
Copy link

github-actions bot commented Feb 6, 2022

🎉 This issue has been resolved in version 26.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants