Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrating Files To Typescript #2637

Closed
1 task done
naman9271 opened this issue Feb 13, 2025 · 6 comments · Fixed by #2663 · 4 remaining pull requests
Closed
1 task done

Migrating Files To Typescript #2637

naman9271 opened this issue Feb 13, 2025 · 6 comments · Fixed by #2663 · 4 remaining pull requests

Comments

@naman9271
Copy link
Contributor

naman9271 commented Feb 13, 2025 •
edited
Loading

Migrating Files to Typescript

  • Yes, I am willing to submit a PR
@naman9271
Copy link
Contributor Author

Hey @jallamsetty1 @saghul @bgrozev , Please review this issue and assign me so that i open a PR for this

@damencho
Copy link
Member

We do not assign people. Just open a PR and we can review it.

@naman9271 naman9271 mentioned this issue Feb 14, 2025
Closed
10 tasks
@naman9271 naman9271 changed the title Missing/Incomplete TypeScript Typings for modules/RTC Files Migrating modules/RTC Files To Typescript Feb 20, 2025
This was referenced Feb 20, 2025
Open
Open
Open
Open
Open
@naman9271 naman9271 changed the title Migrating modules/RTC Files To Typescript Migrating ` Files To Typescript Feb 24, 2025
@naman9271 naman9271 changed the title Migrating ` Files To Typescript Migrating Files To Typescript Feb 24, 2025
This was referenced Feb 24, 2025
Open
Open
Open
Open
Merged
Open
@naman9271
Copy link
Contributor Author

@saghul, I have submitted the PRs for the migration of a single file as per your earlier suggestion. Additionally, I have migrated 5+ more files locally apart from these, but to maintain clarity and avoid clutter, I believe it would be best to have the initial PRs reviewed first. Please take a look when you have the time.

@naman9271
Copy link
Contributor Author

Hey @jallamsetty1, @saghul , I believe this issue may have been closed inadvertently, as there are still 10 open PRs related to it. Additionally, I have locally migrated more files. Could you kindly review the pending PRs? Thanks!

@saghul
Copy link
Member

saghul commented Feb 27, 2025

We'll get through them, thank you for sending them!

@naman9271
Copy link
Contributor Author

"Thank you! @saghul I appreciate your time and effort in reviewing them. Let me know if any changes are needed."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@saghul @damencho @naman9271