Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for broken Makefile on OS X with homebrew #12

Open
josegonzalez opened this issue Apr 3, 2012 · 1 comment
Open

Fix for broken Makefile on OS X with homebrew #12

josegonzalez opened this issue Apr 3, 2012 · 1 comment

Comments

@josegonzalez
Copy link

From logs:

so idk enough about bash to make the pr myself
but I have a small change to the grok makefile to make it work on os x
or at least with homebrew

    if command -v brew >/dev/null; then
    PREFIX?=$(brew --prefix)
    end

right around here: https://github.com/jordansissel/grok/blob/master/Makefile
That will make grok compile correctly under homebrew, assuming you have libevent and tokyo cabinet installed. I tried searching for directions yesterday, but failed to find how to make multiple if statements
@ryandesign
Copy link

I would encourage the developer of grok to decline to make any such package-manger-specific changes to the code. Just because Homebrew is installed on a system does not mean that any compilation of grok should end up in the Homebrew prefix. It would be reasonable to expect any Homebrew formula for grok to set the prefix correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants