karate.abort() and subsequent steps will be set as passed not skipped #755

this is not ideal but because of the behavior of the 3rd party report - see issue details and thread for more

Author: ptrthomas

karate-core/src/main/java/com/intuit/karate/core/Result.java

@@ -96,7 +96,7 @@ public static Result skipped() {
     }
 
     public static Result aborted(long nanos) {
-        return new Result(SKIPPED, nanos, null, true);
+        return new Result(PASSED, nanos, null, true);
     }
 
     public String getStatus() {

karate-core/src/main/java/com/intuit/karate/core/ScenarioExecutionUnit.java

@@ -48,6 +48,7 @@ public class ScenarioExecutionUnit implements Runnable {
     private List<Step> steps;
     private StepActions actions;
     private boolean stopped = false;
+    private boolean aborted = false;
     private StepResult lastStepResult;
     private Runnable next;
     private boolean last;
@@ -192,13 +193,14 @@ public void reset(ScenarioContext context) {
     public StepResult execute(Step step) {
         boolean hidden = step.isPrefixStar() && !step.isPrint() && !actions.context.getConfig().isShowAllSteps();
         if (stopped) {
-            return new StepResult(hidden, step, Result.skipped(), null, null, null);
+            return new StepResult(hidden, step, aborted ? Result.passed(0) : Result.skipped(), null, null, null);
         } else {
             Result execResult = Engine.executeStep(step, actions);
             List<FeatureResult> callResults = actions.context.getAndClearCallResults();
             // embed collection for each step happens here
             List<Embed> embeds = actions.context.getAndClearEmbeds();
             if (execResult.isAborted()) { // we log only aborts for visibility
+                aborted = true;
                 actions.context.logger.debug("abort at {}", step.getDebugInfo());
             } else if (execResult.isFailed()) {
                 actions.context.setScenarioError(execResult.getError());

karate-core/src/test/java/com/intuit/karate/core/FeatureResultTest.java

@@ -88,9 +88,9 @@ public void testAbortMultiScenarioFeature() throws Exception {
         // skip-pass and skip-fail both should have all steps as skipped
         // TODO: generate the expected content string, below code puts a hard dependency
         // with KarateJunitFormatter$TestCase.addStepAndResultListing()
-        assertTrue(contents.contains("* karate.abort() .......................................................... skipped"));
-        assertTrue(contents.contains("* assert a == 1 ........................................................... skipped"));
-        assertTrue(contents.contains("* assert a == 2 ........................................................... skipped"));
+        assertTrue(contents.contains("* karate.abort() .......................................................... passed"));
+        assertTrue(contents.contains("* assert a == 1 ........................................................... passed"));
+        assertTrue(contents.contains("* assert a == 2 ........................................................... passed"));
 
         // noskip should have both steps as passed
         assertTrue(contents.contains("Then assert a != 3 ........................................................ passed"));

karate-demo/src/test/java/demo/abort/abort.feature

@@ -1,4 +1,3 @@
-@ignore
 Feature: abort should skip (but not fail) a test
 
 Scenario: you can conditionally exit a test

karate-netty/README.md

@@ -570,6 +570,8 @@ So you have control before and after the actual call, and you can modify the req
 # Stopping
 A simple HTTP `GET` to `/__admin/stop` is sufficient to stop a running server gracefully. So you don't need to resort to killing the process, which can lead to issues especially on Windows - such as the port not being released.
 
+> Tip: for stopping HTTPS servers, you can use [curl](https://curl.haxx.se) like this: `curl -k https://localhost:8443/__admin/stop`
+
 If you have started the server programmatically via Java, you can keep a reference to the `FeatureServer` instance and call the `stop()` method. Here is an example: [ConsumerUsingMockTest.java](../karate-demo/src/test/java/mock/contract/ConsumerUsingMockTest.java).
 
 # Other Examples