Prevent Azure machinery form prematurely deleting machines, leading to sqlalchemy.orm.exc.StaleDataError.

Author: ChrisThibodeaux

lib/cuckoo/core/machinery_manager.py

@@ -297,7 +297,7 @@ def scale_pool(self, machine: Machine) -> None:
     def start_machine(self, machine: Machine) -> None:
         if (
             isinstance(self.machine_lock, ScalingBoundedSemaphore)
-            and self.db.count_machines_running <= self.machines_limit
+            and self.db.count_machines_running() <= self.machines_limit
             and self.machine_lock._value == 0
         ):
             self.machine_lock.release()

modules/machinery/az.py

@@ -466,8 +466,9 @@ def stop(self, label):
                 time.sleep(5)
                 with reimage_lock:
                     label_in_reimage_vm_list = label in [f"{vm['vmss']}_{vm['id']}" for vm in reimage_vm_list]
-        else:
-            self.delete_machine(label)
+        # TODO: Find a way to enable machine deletion here without causing a sqlalchemy.orm.exc.StaleDataError
+        # else:
+        #     self.delete_machine(label)
 
     def availables(self, label=None, platform=None, tags=None, arch=None, include_reserved=False, os_version=[]):
         """