-
Notifications
You must be signed in to change notification settings - Fork 813
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feedback Requested] Intent to default to EKS-D sidecars #1456
Comments
Can you start with an outline of underlying reasoning that prompted this decision? |
|
What does it mean to "switch" sidecar images? Given that this is a Kubernetes SIG project and not an AWS project as such, at least helm chart and e2e tests should at minimum contain tests using the upstream images. I am perfectly fine with offering a separate values file with the EKS-D images though. |
Sorry, slightly bad wording on my part. We'd like to switch the default sidecars for the Helm chart (and ECR overlay for the manual manifests) to the EKS-D versions, such as how the EFS driver currently does it (or how the Azuredisk CSI Driver does it for sidecars hosted on MCR). No changes will be made to the parameter names or how they work, so users can override this default with any sidecars they wish. EDIT: changed the issue title and description to make it more clear we want to change the default, not start hardcoding the sidecars or something weird like that. |
We plan to switch the default sidecar images from our current sidecar images (hosted on GCR) to sidecars from the EKS-Distro project (hosted on ECR) in the near future (likely release 1.15.0, which will be available in January).
The GCR overlay will continue to use the existing sidecar images and will not be switched. We we bump the version on these sidecars on a best-effort basis, but will no longer release any custom versions with fixes.
Please use this issue to provide any comments or feedback on this change.
The text was updated successfully, but these errors were encountered: