Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Expose sidecar resources in the add-on configuration #2371

Open
NicholasRaymondiSpot opened this issue Feb 27, 2025 · 1 comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@NicholasRaymondiSpot
Copy link

Is your feature request related to a problem? Please describe.
In our current helm chart deployment, we provide overrides for some of our sidecar containers:

  sidecars:
    provisioner:
      resources:
        requests:
          cpu: 50m
          memory: 64Mi
        limits:
          memory: 512Mi
    attacher:
      resources:
        requests:
          cpu: 20m
    livenessProbe:
      resources:
        requests:
          cpu: 20m
          memory: 32Mi
        limits:
          memory: 256Mi

However the current EBS add-on configuration schema only allows for setting controller & node resource overrides. The others only expose additionalArgs:

"sidecars": {
    "additionalProperties": false,
    "properties": {
      "attacher": {
        "additionalProperties": false,
        "properties": {
          "additionalArgs": {
            "default": [],
            "description": "Additional arguments passed to the attacher container",
            "items": {
              "type": "string"
            },
            "type": "array"
          }
        },
        "type": "object"
      },
      "livenessProbe": {
        "additionalProperties": false,
        "properties": {
          "additionalArgs": {
            "default": [],
            "description": "Additional arguments passed to the livenessprobe container",
            "items": {
              "type": "string"
            },
            "type": "array"
          }
        },
        "type": "object"
      },
      "provisioner": {
        "additionalProperties": false,
        "properties": {
          "additionalArgs": {
            "default": [],
            "description": "Additional arguments passed to the provisioner container",
            "items": {
              "type": "string"
            },
            "type": "array"
          }
        },
        "type": "object"
      }

Describe the solution you'd like in detail
Please add resource properties to each of the sidecar containers so we can manage the resource requests & limits for these deployments.

Describe alternatives you've considered
We're sticking with Helm charts for now, removing these resources causes issues when our clusters take on heavy workloads.

Additional context
N/A

@torredil
Copy link
Member

Hi there @NicholasRaymondiSpot

Thank you for the request. We plan to expose these parameters in the 1.41 release.

/retitle [Enhancement] Expose sidecar resources in the add-on configuration
/kind feature

@k8s-ci-robot k8s-ci-robot changed the title Expose sidecar resources in the add-on configuration [Enhancement] Expose sidecar resources in the add-on configuration Feb 27, 2025
@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

3 participants