Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ WIP: Feat dedicated hosts #5344

Closed
wants to merge 12 commits into from
Closed

✨ WIP: Feat dedicated hosts #5344

wants to merge 12 commits into from

Conversation

faermanj
Copy link
Contributor

What type of PR is this?

/kind feature

What this PR does / why we need it:

Add dedicated host configuration to spec and runInstances call
For initial feedback only, will open a new one with final implementation.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #5194

Special notes for your reviewer:
For initial feedback only, will open a new one with final implementation.

Checklist:

  • squashed commits
  • includes documentation
  • includes emoji in title
  • adds unit tests
  • adds or updates e2e tests

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. kind/feature Categorizes issue or PR as related to a new feature. labels Feb 10, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign ankitasw for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 10, 2025
@k8s-ci-robot k8s-ci-robot requested review from cnmcavoy and nrb February 10, 2025 18:24
@k8s-ci-robot k8s-ci-robot added needs-priority needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 10, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @faermanj. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Feb 10, 2025
@richardcase
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 17, 2025
@k8s-ci-robot
Copy link
Contributor

@faermanj: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cluster-api-provider-aws-test 59c3ab5 link true /test pull-cluster-api-provider-aws-test
pull-cluster-api-provider-aws-verify 59c3ab5 link true /test pull-cluster-api-provider-aws-verify

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@faermanj
Copy link
Contributor Author

@richardcase even after make generate I'm still facing this issue, if you'd have any advice...

Error from server (BadRequest): error when creating "/home/faermanj/go/src/faermanj/cluster-api-provider-aws/examples/dedicated-hosts/tmp/capa-dedicated-host.yaml": AWSMachineTemplate in version "v1beta2" cannot be handled as a AWSMachineTemplate: strict decoding error: unknown field "spec.template.spec.hostAffinity", unknown field "spec.template.spec.hostId"

@richardcase
Copy link
Member

@richardcase even after make generate I'm still facing this issue, if you'd have any advice...

Error from server (BadRequest): error when creating "/home/faermanj/go/src/faermanj/cluster-api-provider-aws/examples/dedicated-hosts/tmp/capa-dedicated-host.yaml": AWSMachineTemplate in version "v1beta2" cannot be handled as a AWSMachineTemplate: strict decoding error: unknown field "spec.template.spec.hostAffinity", unknown field "spec.template.spec.hostId"

I'll have a look

richardcase
richardcase reviewed Feb 18, 2025
View reviewed changes
api/v1beta2/types.go Outdated

// Affinity specifies the dedicated host affinity setting for the instance.
// +optional
HostAffinity *string `json:"hostId,omitempty"`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
HostAffinity *string `json:"hostId,omitempty"`
HostAffinity *string `json:"hostAffinity,omitempty"`

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll then have issues with the fuzzy tests.

@richardcase
Copy link
Member

@faermanj - will send you a diff via slack with some changes.

@k8s-ci-robot
Copy link
Contributor

Adding label do-not-merge/contains-merge-commits because PR contains merge commits, which are not allowed in this repository.
Use git rebase to reapply your commits on top of the target branch. Detailed instructions for doing so can be found here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@faermanj faermanj closed this by deleting the head repository Feb 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardcase richardcase richardcase left review comments

@cnmcavoy cnmcavoy Awaiting requested review from cnmcavoy

@nrb nrb Awaiting requested review from nrb

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/contains-merge-commits do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/feature Categorizes issue or PR as related to a new feature. needs-priority ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support EC2 dedicated hosts
3 participants
@faermanj @k8s-ci-robot @richardcase