Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate test object creation under the wrappers pkg #353

Open
ahg-g opened this issue Feb 17, 2025 · 0 comments
Open

Consolidate test object creation under the wrappers pkg #353

ahg-g opened this issue Feb 17, 2025 · 0 comments
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.

Comments

@ahg-g
Copy link
Contributor

ahg-g commented Feb 17, 2025

In a few places in tests we create pools, models and pods. We used at the wrapper pattern in a few projects and it worked generally well. I think we can follow the same pattern here.

#350 introduces the wrapper pkg and adds the PodWrapper, we can follow up with InferencePoolWrapper, InferenceModelWrapper, PodMetricsWrapper and RequestWrapper (for which we have some functions that we can repurpose https://github.com/kubernetes-sigs/gateway-api-inference-extension/blob/main/pkg/ext-proc/test/utils.go#L63).

@kfswain kfswain added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.
Projects
None yet
Development

No branches or pull requests

2 participants