-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wait for the webhook service to be listening before advertising the Jobset replica as ready. #607
Comments
+1 in Kueue we use readiness probes to delay marking the deployment as available until the webhook service is ready. This allows users to wait for the webhooks service by waiting for availability of the deployment. We use this mechanism in kueue e2e tests here, but it can also be checked conveniently by users by |
Sounds very sane. @mbobrovskyi would you want to contribute a patch? |
Yes. /assign |
Makes sense, thanks for working on this @mbobrovskyi |
What would you like to be added:
As mentioned on the title, wait for the webhook service to be listening before advertising the Jobset replica as ready. Like on the kueue here.
Why is this needed:
It causes flakes in kueue https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/kubernetes-sigs_kueue/2408/pull-kueue-test-e2e-main-1-28/1802723422271180800. To fix it we need to wait for jobset operator ready and to be sure that webhooks runs success.
The text was updated successfully, but these errors were encountered: