Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add disabled waitForPodsReady to configuration by default. #4067

Open
3 tasks
PBundyra opened this issue Jan 27, 2025 · 10 comments · May be fixed by #4265
Open
3 tasks

Add disabled waitForPodsReady to configuration by default. #4067

PBundyra opened this issue Jan 27, 2025 · 10 comments · May be fixed by #4265
Assignees
@OMNARAYANYU
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature.

Comments

@PBundyra
Copy link
Contributor

What would you like to be added:
I'd like to add waitForPodsReady to configuration by default, which is now commented out. It shouldn't have any impact though as it's disabled by default.

Why is this needed:
This will increase consistency in the defaults.go file.

Completion requirements:

This enhancement requires the following artifacts:

  • Design doc
  • API change
  • Docs update

The artifacts should be linked in subsequent comments.
@PBundyra PBundyra added the kind/feature Categorizes issue or PR as related to a new feature. label Jan 27, 2025
@kannon92
Copy link
Contributor

kannon92 commented Jan 28, 2025 •
edited
Loading

/help
/good-first-issue

You want to add this as default with WaitForPodsReady disabled?

https://github.com/kubernetes-sigs/kueue/blob/main/config/components/manager/controller_manager_config.yaml#L26

Just uncomment WaitForPodsReady and disable it?

@k8s-ci-robot
Copy link
Contributor

@kannon92:
This request has been marked as suitable for new contributors.

Guidelines

Please ensure that the issue body includes answers to the following questions:

  • Why are we solving this issue?
  • To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
  • Does this issue have zero to low barrier of entry?
  • How can the assignee reach out to you for help?

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

/help
/good-first-issue

You want to add this as default with WaitForPodsReady disabled?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Jan 28, 2025
@OMNARAYANYU
Copy link

/assign

@PBundyra
Copy link
Contributor Author

/help /good-first-issue

You want to add this as default with WaitForPodsReady disabled?

https://github.com/kubernetes-sigs/kueue/blob/main/config/components/manager/controller_manager_config.yaml#L26

Just uncomment WaitForPodsReady and disable it?

Exactly

OMNARAYANYU added a commit to OMNARAYANYU/kueue that referenced this issue Feb 15, 2025
@OMNARAYANYU
adding fix for the issue kubernetes-sigs#4067
97c8f2e
@OMNARAYANYU OMNARAYANYU linked a pull request Feb 15, 2025 that will close this issue
Open
@tenzen-y
Copy link
Member

IIUC, if waitForPodsReady is null, we do not configure it:

kueue/apis/config/v1beta1/defaults.go

Line 119 in 06d4c76

if cfg.WaitForPodsReady != nil {

So, my question is, what is the motivation to configure those parameters by default?

@OMNARAYANYU
Copy link

IIUC, if waitForPodsReady is null, we do not configure it:

kueue/apis/config/v1beta1/defaults.go

Line 119 in 06d4c76

if cfg.WaitForPodsReady != nil {
So, my question is, what is the motivation to configure those parameters by default?

are you recommending this to be an invalid issue?

@tenzen-y
Copy link
Member

IIUC, if waitForPodsReady is null, we do not configure it:
kueue/apis/config/v1beta1/defaults.go
Line 119 in 06d4c76
if cfg.WaitForPodsReady != nil {
So, my question is, what is the motivation to configure those parameters by default?

are you recommending this to be an invalid issue?

Sorry for your confusion. I would like to ask this to @PBundyra

@PBundyra
Copy link
Contributor Author

My primary motivation was to increase consistency across the defaults.go file. Than we could also default the values there, and disable it by default. However with the new changes to the waitForPodsReady field and taking into the account the discussion here I would abandon this idea. Sorry for the late reply

@PBundyra
Copy link
Contributor Author

Sorry for the confusion

@PBundyra
Copy link
Contributor Author

PBundyra commented Feb 26, 2025 •
edited
Loading

After some discussions with @mimowo we came to the conclusion that we wouldn't like to uncomment waitForPodsReady field in the Kueue config but rather just stick with cleaning up the defaults.go file, so it's consistent with other config fields

@PBundyra PBundyra reopened this Feb 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@OMNARAYANYU OMNARAYANYU

Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Milestone
No milestone
5 participants
@kannon92 @k8s-ci-robot @OMNARAYANYU @tenzen-y @PBundyra