Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create an e2e customconfig test that tests WaitForPodsReady #4429

Open
1 task
PBundyra opened this issue Feb 27, 2025 · 1 comment
Open
1 task

Create an e2e customconfig test that tests WaitForPodsReady #4429

PBundyra opened this issue Feb 27, 2025 · 1 comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@PBundyra
Copy link
Contributor

What would you like to be added:
An e2e tests with falls under the customconfigs/ directory that would test WaitForPodsReady feature. We already have integration tests for WaitForPodsReady but they don't run job controller, so it would be nice to have some scenarios with job controller covered.

Scenarios:

  • .timeout is surpassed before all pods reach readiness - the workload is evicted, and requeued
  • during runtime a pod fails, and .recoveryTimeout is surpassed - the workload is evicted and requeued
  • during runtime a pod fails, and the recovery pod is scheduled before .recoveryTimeout is surpassed - the workload continues to run

Why is this needed:

Completion requirements:

This enhancement requires the following artifacts:

  • Code changes

The artifacts should be linked in subsequent comments.

@PBundyra PBundyra added the kind/feature Categorizes issue or PR as related to a new feature. label Feb 27, 2025
@mimowo
Copy link
Contributor

mimowo commented Feb 27, 2025

+1, waitForPodsReady is quite an important feature for our users for failure recovery. I think it deserves at least a baseline e2e test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

2 participants