Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ClusterQueueReference to improve static code analysis #4442

Open
mimowo opened this issue Feb 28, 2025 · 1 comment
Open

Use ClusterQueueReference to improve static code analysis #4442

mimowo opened this issue Feb 28, 2025 · 1 comment
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.

Comments

@mimowo
Copy link
Contributor

mimowo commented Feb 28, 2025

What would you like to be added:

I would like to review all places in code which use string to represent ClusterQueue and replace with ClusterQueueReference. Some candidate places:

https://github.com/kubernetes-sigs/kueue/blob/6e25ebfcf2491236e385f644e4f7280c3d315ead/pkg/cache/snapshot.go#L39C2-L39C26

ClusterQueues map[string]CQ

but likely many more. It is ok to miss some, but we would like to set the direction.

Why is this needed:

To make it easier to analyze the code and see what the "string" is.

@mimowo mimowo added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Feb 28, 2025
@mimowo
Copy link
Contributor Author

mimowo commented Feb 28, 2025

Follow up to #4417

cc @vladikkuzn @PBundyra @tenzen-y

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.
Projects
None yet
Development

No branches or pull requests

1 participant