-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kustomize version is always devel, but should be v5.x.x #5339
Comments
Seems like the go build of kustomize isnt getting tagged with version. But brew installation does have proper tag of version |
Will need to look into how to pass version when building with go. Otherwise commit id will be added in place of version. |
This is how we do in some of the operator-framework projects. Adding info here in case it helps in fixing the issue: The buildinfo returns debug.Module (https://cs.opensource.google/go/go/+/refs/tags/go1.21.1:src/runtime/debug/mod.go;l=62), which contains all the dependencies of the build. We search for latest tag for our module (eg: https://github.com/operator-framework/helm-operator-plugins/blob/d00d0092fe5c2a7776a678b7dcee4085cbccfe01/internal/version/version.go#L67), it would be sigs.k8s.io/kustomize/kustomize in our case, and I assume it would give us the tag with which we add could |
/assign |
What happened?
I have a part of Makefile to download kustomize and check that it is of recent v5, and I want a semver out of
kustomize version
call.What did you expect to happen?
How can we reproduce it (as minimally and precisely as possible)?
Expected output
No response
Actual output
No response
Kustomize version
v5.1.0
Operating system
Linux
The text was updated successfully, but these errors were encountered: