Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some files can be attached but not synced back #11887

Open
ZornHadNoChoice opened this issue Feb 25, 2025 · 5 comments
Open

Some files can be attached but not synced back #11887

ZornHadNoChoice opened this issue Feb 25, 2025 · 5 comments
Labels
bug It's a bug

Comments

@ZornHadNoChoice
Copy link

ZornHadNoChoice commented Feb 25, 2025

Operating system

Android

Joplin version

3.2.7

Desktop version info

No response

Current behaviour

TL;DR: I attached a large video and after reinstalling Joplin, it cannot sync the video.

I had a note containing a 166,727,097 Bytes video. I was using version 2.11.32 (I know, it's quite old!) and today I decided to update Joplin.

Unfortunately, I uninstalled the app since F-Droid said so, but then I saw that F-Droid's version had some differences from the "official release" so I installed it from the play store instead.

I set the sync target to "File system" and everything synchronized fine, except for the video mentioned above.

Luckily, I got the video back from the bin in my gallery app. I successfully re-attached the video to the note. I also tested doing the whole thing again but with installing the same Joplin version (2.11.32) and the problem still occurred.

Image

Image

Image
v2.11.32 didn't show this error message.

Expected behaviour

Allow the user to sync larger files. The 100,000,000 bytes limit is a bit too small.

Alternatively, don't let the user attach files that can't be synced back.

Logs

mobile-log.log

@ZornHadNoChoice ZornHadNoChoice added the bug It's a bug label Feb 25, 2025
@mrjo118
Copy link
Contributor

mrjo118 commented Feb 26, 2025

It's not clear at what point the error in the 3rd screenshot occurs.

The error / message in the first 2 screenshots would be by design. But the error in the 3rd screenshot would be a bug.

What screen / action causes the error in the 3rd screenshot and is that in addition to seeing the orange banner and the message on the more info screen, or do you no longer see the messages as per the first 2 screenshots when using 3.2.7?

EDIT: Is the error in the 3rd screenshot what you get when you open the resource within the note that uses it? Presumably you didn't get that error in the older version of Joplin because it allowed you to download a larger attachment on mobile. But I guess the attachment size limit on mobile has been decreased now as an imposed limitation to prevent crashes

@mrjo118
Copy link
Contributor

mrjo118 commented Feb 26, 2025

So the relevant code which sets the 100mb limit has actually been in place for over 4 years. I'm guessing the F-droid varient of Joplin removes this restriction, which does beg to question if the restriction is outdated and should be increased to a higher value now that phones are more powerful, at least on newer versions of Android

@ZornHadNoChoice
Copy link
Author

It's not clear at what point the error in the 3rd screenshot occurs.

After syncing and taking the first two screenshots, I tapped on the purple link in the third screenshot and got the error. I did the exact same thing with the older version and I didn't get an error (I don't have a screenshot but it showed a popup saying the file doesn't exist or something and had an "ok" button).

The error / message in the first 2 screenshots would be by design. But the error in the 3rd screenshot would be a bug.

I get that they are by design, but having a limit on syncing and no limit on attaching files.

What screen / action causes the error in the 3rd screenshot and is that in addition to seeing the orange banner and the message on the more info screen, or do you no longer see the messages as per the first 2 screenshots when using 3.2.7?

I already answered most of this. The orange banner and the more info screen remained there until I closed the app.

EDIT: Is the error in the 3rd screenshot what you get when you open the resource within the note that uses it?

yes

@ZornHadNoChoice
Copy link
Author

ZornHadNoChoice commented Feb 26, 2025

I'm guessing the F-droid varient of Joplin removes this restriction

Just to be clear, I never used the F-Droid version. I saw Joplin in the F-Droid app and wanted to update it using it.

@mrjo118
Copy link
Contributor

mrjo118 commented Feb 26, 2025

Ok, so the 100mb restriction was in place in the older version, but the error message when opening the resource was a user friendly one instead of the one on the third screenshot?

If so, then the new error message is a regression

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug It's a bug
Projects
None yet
Development

No branches or pull requests

2 participants