Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot go from vertical-perspective to globe projection #5114

Closed
jonathanlurie opened this issue Nov 25, 2024 · 2 comments · Fixed by #5139
Closed

Cannot go from vertical-perspective to globe projection #5114

jonathanlurie opened this issue Nov 25, 2024 · 2 comments · Fixed by #5139

Comments

@jonathanlurie
Copy link
Contributor

maplibre-gl-js version: 5.0.0-pre.7

browser: Chrome Version 130.0.6723.117 (Official Build) (arm64) (MacOS, M2)

Steps to Trigger Behavior

  1. map.setProjection({type: "vertical-perspective"})
  2. map.setProjection({type: "globe"})
  3. map.getProjection() still shows .type being "vertical-perspective" , instead of "globe"

Expected Behavior

After calling map.setProjection({type: "vertical-perspective"}) and then map.setProjection({type: "globe"}), we should get a .type value being "globe" when calling map.getProjection().

Actual Behavior

After calling map.setProjection({type: "vertical-perspective"}) and then map.setProjection({type: "globe"}), we still have a .type value of "vertical-perspective" when calling map.getProjection().

This means the animation is not possible from vertical-perspective directly to globe (where the animation should actually hardly show, since both are globe)

@HarelM
Copy link
Collaborator

HarelM commented Nov 25, 2024

This is currently planned to be solved as part of version 5.
globe is not a projection, but a preset of vertical-perspective and mercator for different zoom levels.

Feel free to push this forward if you are eager to see this get it in.
CC: @birkskyum

@HarelM
Copy link
Collaborator

HarelM commented Dec 3, 2024

This will hopefully be solved with:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants