Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhanced PSF Interface with Flattened Field Inputs #6

Open
dongx-psu opened this issue Jun 15, 2019 · 0 comments
Open

Enhanced PSF Interface with Flattened Field Inputs #6

dongx-psu opened this issue Jun 15, 2019 · 0 comments
Labels
enhancement New feature or request

Comments

@dongx-psu
Copy link
Collaborator

dongx-psu commented Jun 15, 2019

To support #3 , we need to enhance the PSF definition and usage interface so that user can check and make decisions on wildcard based fields.

The API (example for inline PSF) can be like this:

fishstore::core::NullableInt foo(const std::vector<std::pair<uint16_t, typename adapter_t::field_t>>& fields)

In such API, along with parsed field, corresponding field ID is given for users to refer. Field ID should be relative one in PSF making function. This means field 0 referred in the API above is refer to the first field provided in MakeInlinePSF().

Internal value passing logic in BatchInsert should be altered to match this new feature as well.

@dongx-psu dongx-psu added the enhancement New feature or request label Jun 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant