Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Importing chapters shifts all labels "up" one and ignores final chapter #2339

Open
4 tasks done
DashingDave opened this issue Feb 26, 2025 · 0 comments
Open
4 tasks done

Comments

@DashingDave
Copy link

The fewer issues I have to read, the more new features I will have time to implement, so I ask that you please try these things first

Operating System

MacOS 15

Steps to reproduce

  1. Toggle "Ask about importing chapters from opened file" option to ON position
  2. Drag a movie file (in my case, an .m4v) into LLC and choose "Import Chapters"

Expected behavior

As a simplified example, if the chapter listings in a 3-minute long video are
"Monday" 0:00
"Tuesday" 0:48
"Wednesday" 1:22
"Thursday" 2:01
"Friday" 2:31

then LLC would produce the following segments:
"Monday" 0:00 - 0:48
"Tuesday" 0:48 - 1:22
"Wednesday" 1:22 - 2:01
"Thursday" 2:01 - 2:31
"Friday" 2:31 - 3:00

Actual behavior

Continuing with the previous example, where the chapters in the 3-minute video are
"Monday" 0:00
"Tuesday" 0:48
"Wednesday" 1:22
"Thursday" 2:01
"Friday" 2:31

then LLC produces the following segments:
"Tuesday" 0:00 - 0:48
"Wednesday" 0:48 - 1:22
"Thursday" 1:22 - 2:01
"Friday" 2:01 - 3:00

Share log from developer tools

(The issue appears to be that LLC is designating the first segment/chapter to start at a negative time value.)

index.tsx:71 Version 3.64.0
App.tsx:1679 userOpenFiles
App.tsx:1680 /Volumes/GoldHD/Movies/DVD Bonuses for ATV Purchased Shows/Futurama/Season 6/Deleted Scenes 3.m4v
ffmpeg.ts:271 FFprobe detected format(s) mov,mp4,m4a,3gp,3g2,mj2
App.tsx:1332 loadMedia /Volumes/GoldHD/Movies/DVD Bonuses for ATV Purchased Shows/Futurama/Season 6/Deleted Scenes 3.m4v /Users/dave/Movies undefined
App.tsx:543 State reset
App.tsx:1269 Convert chapters to segments (13) [{…}, {…}, {…}, {…}, {…}, {…}, {…}, {…}, {…}, {…}, {…}, {…}, {…}]0: {start: -59.576178, end: 0, name: 'Yo Leela Leela 1'}end: 0name: "Yo Leela Leela 1"start: -59.576178[[Prototype]]: Object1: {start: 0, end: 32.298933, name: 'Yo Leela Leela 2'}2: {start: 32.298933, end: 167.834333, name: 'Yo Leela Leela 3'}3: {start: 167.834333, end: 201.8016, name: 'Fry Am the Eggman 1'}4: {start: 201.8016, end: 233.099533, name: 'Fry Am the Eggman 2'}5: {start: 233.099533, end: 263.496567, name: 'Cold Warriors 1'}6: {start: 263.496567, end: 283.049422, name: 'Cold Warriors 2'}7: {start: 283.049422, end: 310.943967, name: 'Overclockwise 1'}8: {start: 310.943967, end: 331.397733, name: 'Overclockwise 2'}9: {start: 331.397733, end: 351.017333, name: 'Overclockwise 3'}10: {start: 351.017333, end: 370.603567, name: 'Overclockwise 4'}11: {start: 370.603567, end: 412.779033, name: 'Overclockwise 5'}12: {start: 412.779033, end: 506.212489, name: 'Reincarnation'}length: 13[[Prototype]]: Array(0)
useVideo.ts:105 onDurationChange 506.261333
useThumbnails.ts:50 Cleanup thumbnails []

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant