Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct matrix.d.ts file. #86

Merged
merged 4 commits into from
Mar 16, 2019
Merged

Correct matrix.d.ts file. #86

merged 4 commits into from
Mar 16, 2019

Conversation

lightrabbit
Copy link
Contributor

Add method declaration rows, columns, addRow and addColumn to typings.
Correct pseudoInverse parameter type, threshold is a optional parameter.
Correct Matrix extends. In Javascript code, Matrix inherits from Array.

correct `pseudoInverse` parameter type.
correct `Matrix` extends.
@codecov
Copy link

codecov bot commented Feb 18, 2019

Codecov Report

Merging #86 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #86   +/-   ##
=======================================
  Coverage   61.94%   61.94%           
=======================================
  Files          25       25           
  Lines        2252     2252           
  Branches      280      280           
=======================================
  Hits         1395     1395           
  Misses        779      779           
  Partials       78       78

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 690edd1...a01694d. Read the comment docs.

@poteat
Copy link

poteat commented Mar 15, 2019

This would be good too merge in. I had to write an explicit parameter today for psuedoInverse even though it's optional.

@lightrabbit Nice work. Out of curiosity why the change

fill(value: number): Matrix;

to

fill(value: number): this;

?

@lightrabbit
Copy link
Contributor Author

@poteat This chagne use a TypeScript feature named polymorphic this types.
Because in Matrix's source code, Matrix#fill returns this. And this makes the class Matrix easier to extend.

Copy link
Member

@targos targos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@targos targos merged commit ebb273c into mljs:master Mar 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants